don't show "pmm queries" from QAN

Description

Customers get very confused seeing “PMM queries” in their QAN. These are queries like show replica status, show global variables, select from perf_schema.events…, etc.

Can these queries be auto-filtered in QAN? Since PMM supports parsing query comments, can we add something like /* source=PMM */ to all queries and auto-filter them?

(This issue is separate from the PMM server queries against the internal pgsql server; we shouldn’t see those either by default.)

How to test

None

How to document

None

Activity

Show:

Nurlan Moldomurov February 20, 2025 at 1:01 PM

That PR was created 7 years ago by Aleksi who was lead of PMM team at that moment.

Nurlan Moldomurov February 20, 2025 at 1:00 PM

it wasn’t about filtering on exporter, but adding additional comment to exporter queries and convert them to label in QAN agent.

Matthew Boehm February 19, 2025 at 4:44 PM

Looks like upstream has a WIP for this, https://github.com/prometheus/mysqld_exporter/pull/331

Matthew Boehm February 19, 2025 at 4:28 PM

I don’t think these should be filtered in the exporter because we would lose all insight. Better to have all queries in PMM, and filter them by default in QAN. There have been reports of PMM queries causing slowness/taking a long time. If we filter at exporter then we’d never be able to see this.

Nurlan Moldomurov November 13, 2024 at 9:28 AM

here was a good comment from about implementing these changes on upstream. In this case it would be easier to manage conflicts.

Details

Assignee

Reporter

Priority

Labels

Needs QA

Yes

Needs Doc

Yes

Planned Version/s

Smart Checklist

Created October 30, 2024 at 3:50 PM
Updated February 20, 2025 at 1:01 PM