Incompatible pmm-admin options: '--disable-queryexamples' and '--query-source=perfschema'
Description
How to test
How to document
AFFECTED CS IDs
Attachments
Smart Checklist
Activity
Jira Bot August 28, 2020 at 11:56 AM
To: Former user
CC:
Hi, I'm jira-bot, Percona's Jira automation tool. I've detected that someone from
Percona has made an edit to the Summary field of an issue that you reported.
I'm not sentient (yet) so I'm not sure whether the person fixed a typo, changed
a few words, or completely rewrote the text. In any case, it is Percona Engineering's
intention to make the Summary and Description of an issue as accurate as possible
so that we're fixing the actual problem you're encountering, and to avoid
misunderstandings about symptoms and causes.
If the current Summary does not accurately reflect the problem you are reporting,
or if you feel the change was otherwise inappropriate in some way, please add a
new comment explaining things and we'll address it as soon as we can.
This message will be added only once per issue, regardless of how many times
the Summary is edited.
message-code:summary-edited
Issue:
In case of user doesn't want to show a query example which has "Sensitive Data" on PMM Query Analytics UI they can disable it with the help of --disable-queryexamples option in pmm-admin.
But this option is not working as expected when mysql instance added using {{ --query-source perfschema}} option and on PMM Query Analytics UI query Examples is visible with original data.
we do not see this issue when using --query-source slowlog
Reproduciable Testcase:
PMM 2.9.0
Suggested solution:
We don't pass disablequeryexamples value here https://github.com/percona/pmm-agent/blob/859220fb454b9990a8e8851b93f2fa4bbad64046/agents/mysql/perfschema/perfschema.go#L80
Working fine with --query-source slowlog