PMM Server crashes after upgrading to 2.22 every 4 hours

Description

Issue:
--------
After upgrading to 2.22 pmm-managed component crashes with the following error:

It happens every 4 hours and causes problems.

Cause:
----------
Service version check functionality was added in 2.22 ()

In code, we do not check for NIL in response:

The problem is we can receive NIL in case of a communication failure or if a remote pmm-agent has an older version and knows nothing about this kind of request.

Possible solution:
------------------------
Add a simple check "if response == nil" to handle situations like this properly and avoid a pmm-managed crash. E.g. we could log an ERROR/WARNING message and continue.

How to test

None

How to document

None

AFFECTED CS IDs

CS0021975

relates to

Smart Checklist

Activity

Show:

Jira Bot November 23, 2021 at 3:56 PM

To: Former user
CC:

Hi, I'm jira-bot, Percona's Jira automation tool. I've detected that someone from
Percona has made an edit to the Summary field of an issue that you reported.

I'm not sentient (yet) so I'm not sure whether the person fixed a typo, changed
a few words, or completely rewrote the text. In any case, it is Percona Engineering's
intention to make the Summary and Description of an issue as accurate as possible
so that we're fixing the actual problem you're encountering, and to avoid
misunderstandings about symptoms and causes.

If the current Summary does not accurately reflect the problem you are reporting,
or if you feel the change was otherwise inappropriate in some way, please add a
new comment explaining things and we'll address it as soon as we can.

This message will be added only once per issue, regardless of how many times
the Summary is edited.

message-code:summary-edited

Roma Novikov November 1, 2021 at 7:31 AM

This issue sounds related to 

Linking them until we discover the difference between them.  

Done

Details

Assignee

Reporter

Priority

Components

Needs QA

Yes

Fix versions

Story Points

Affects versions

Smart Checklist

Created October 29, 2021 at 11:41 AM
Updated October 9, 2024 at 8:38 AM
Resolved November 15, 2021 at 11:58 AM