Editing a backup storage in a backup schedule for a postgresql database displays an error when 3 backup schedules have been created
Description
Tested with Everest 0.11.0 rc1 version.
Create a postgresql database with 2 nodes. Create one scheduled backup and PITR gets enabled.
After a scheduled backup completes, add some data in the database.
Create another backup storage and create a scheduled backup with this backup storage.
After a scheduled backup completes, add some data in the database.
Create another backup storage and create a third scheduled backup with this backup storage.
After a scheduled backup completes, add some data in the database.
Now if you see the three backup storages, the same PITR logs are available on all of them.
The current state of the database is as follows
Now edit the backup storage in the last backup schedule, it displays an error message
The same error message is displayed if any of the three backup schedules are edited and the backup storage is changed.
If there is only one backup schedule and the backup storage is changed in it, then pg creates another repo for it
So in the above, the repo3 is the previous backup storage and repo2 is the new backup storage for the same schedule.
Hence, I think this issue should also be reproducible if we create 3 backup schedules, take one backup and then try to edit the backup storage in the schedule.
Another scenario, where this issue was coming
Create a postgresql database with 2 nodes. Create one scheduled backup and PITR gets enabled.
After a scheduled backup completes, add some data in the database.
Create another backup storage and change the backup storage in the schedule.
After a scheduled backup completes, add some data in the database.
Take some more scheduled backups.
Create two more backup schedules.
Change the backup storage in one of the schedules, it displays the same error message.
Create a postgresql database with 3 backup schedules
Now edit of backup storage in schedules is disabled for postgresql databases, hence this issue will not come.
Oksana Grishchenko July 22, 2024 at 10:41 AM
The PG limitations from the epic are implemented, so the described problems are not the case anymore bc there is no option to edit the storages anymore. Moving the ticket to Ready for QA in case it needs an additional validation.
Diogo Recharte July 10, 2024 at 5:58 PM
The solution to this issue will be implement as part of the epic.
Tested with Everest 0.11.0 rc1 version.
Create a postgresql database with 2 nodes. Create one scheduled backup and PITR gets enabled.
After a scheduled backup completes, add some data in the database.
Create another backup storage and create a scheduled backup with this backup storage.
After a scheduled backup completes, add some data in the database.
Create another backup storage and create a third scheduled backup with this backup storage.
After a scheduled backup completes, add some data in the database.
Now if you see the three backup storages, the same PITR logs are available on all of them.
The current state of the database is as follows
Now edit the backup storage in the last backup schedule, it displays an error message
The same error message is displayed if any of the three backup schedules are edited and the backup storage is changed.
If there is only one backup schedule and the backup storage is changed in it, then pg creates another repo for it
So in the above, the repo3 is the previous backup storage and repo2 is the new backup storage for the same schedule.
Hence, I think this issue should also be reproducible if we create 3 backup schedules, take one backup and then try to edit the backup storage in the schedule.
Another scenario, where this issue was coming
Create a postgresql database with 2 nodes. Create one scheduled backup and PITR gets enabled.
After a scheduled backup completes, add some data in the database.
Create another backup storage and change the backup storage in the schedule.
After a scheduled backup completes, add some data in the database.
Take some more scheduled backups.
Create two more backup schedules.
Change the backup storage in one of the schedules, it displays the same error message.
Attaching the pg yaml of the database.