[BUG] Unexpected resource creation when the MongoDB CR is already deleted
General
Escalation
General
Escalation
Description
We find that the mongodb operator, after deleting the PVC and removing the finalizer for a CR PerconaServerMongoDB with a non-zero DeletionTimestamp (in checkFinalizers), will continue running the reconciliation logic if there is no error:
err = r.checkFinalizers(cr)
if err != nil {
reqLogger.Error(err, "failed to run finalizers")
return rr, err
}
This can lead to unexpected resource creation, because after removing the finalizer of the CR, the CR is going to be deleted. When the CR is deleted, the resources (e.g., sts, service, secret, etc.) that are owned by the CR will also be deleted. If the operator does not immediately return after removing the finalizer, the original reconcile logic will find these resources do not exist and try to create these resources. For example, in reconsileSSL if the ssl secret does not exist, the operator will create the secret. Such creation is unexpected and unnecessary, as they will be deleted again since the owner does not exist.
Instead of creating the resources that are destined to be deleted immediately, we should make the operator return from reconcile if the pvc is deleted successfully and the finalizer is removed successfully.
Environment
None
Smart Checklist
Activity
Aaditya Dubey June 1, 2022 at 1:55 PM
Hi @sieveteam ,
Thank you for the updates. closing the bug now.
sieveteam May 30, 2022 at 6:25 PM
Hi Aaditya, I think the bug is already fixed in the most recent version.
Aaditya Dubey May 25, 2022 at 9:50 AM
Hi @sieveteam ,
Thank you for the report. please update if issue still persists.
Mykola Marzhan November 6, 2021 at 8:10 AM
please feel free to prepare PR
sieveteam November 5, 2021 at 10:43 PM
We can help to send a PR to make the reconcile early-return if the CR is deleted
We find that the mongodb operator, after deleting the PVC and removing the finalizer for a CR PerconaServerMongoDB with a non-zero DeletionTimestamp (in checkFinalizers), will continue running the reconciliation logic if there is no error:
err = r.checkFinalizers(cr) if err != nil { reqLogger.Error(err, "failed to run finalizers") return rr, err }This can lead to unexpected resource creation, because after removing the finalizer of the CR, the CR is going to be deleted. When the CR is deleted, the resources (e.g., sts, service, secret, etc.) that are owned by the CR will also be deleted. If the operator does not immediately return after removing the finalizer, the original reconcile logic will find these resources do not exist and try to create these resources. For example, in reconsileSSL if the ssl secret does not exist, the operator will create the secret. Such creation is unexpected and unnecessary, as they will be deleted again since the owner does not exist.
Instead of creating the resources that are destined to be deleted immediately, we should make the operator return from reconcile if the pvc is deleted successfully and the finalizer is removed successfully.