Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Users are unable to delete haproxy labels using the field cr.spec.haproxy.labels

Description

What happened?

Having a XtraDB cluster running, we wanted to add some labels to haproxy to help management. We did so by adding those labels in the field cr.spec.haproxy.labels. However, later we found that we couldn't remove labels by deleting labels from cr.spec.haproxy.labels

Steps to Reproduce

First, apply the following CR file to create a haproxy statefulset with label key: value.

apiVersion: pxc.percona.com/v1 kind: PerconaXtraDBCluster metadata: finalizers: - delete-pxc-pods-in-order name: test-cluster spec: haproxy: labels: key: value affinity: antiAffinityTopologyKey: kubernetes.io/hostname enabled: true gracePeriod: 30 image: percona/percona-xtradb-cluster-operator:1.11.0-haproxy imagePullPolicy: IfNotPresent podDisruptionBudget: maxUnavailable: 1 resources: requests: cpu: 100m memory: 512Mi size: 3 allowUnsafeConfigurations: false backup: image: percona/percona-xtradb-cluster-operator:1.11.0-pxc8.0-backup imagePullPolicy: IfNotPresent pitr: enabled: false schedule: - keep: 3 name: sat-night-backup schedule: 0 0 * * 6 storageName: s3-us-west - keep: 5 name: daily-backup schedule: 0 0 * * * storageName: fs-pvc storages: fs-pvc: type: filesystem volume: persistentVolumeClaim: accessModes: - ReadWriteOnce resources: requests: storage: 512Mi s3-us-west: s3: bucket: S3-BACKUP-BUCKET-NAME-HERE credentialsSecret: my-cluster-name-backup-s3 region: us-west-2 type: s3 verifyTLS: true crVersion: 1.11.0 enableCRValidationWebhook: true logcollector: enabled: true image: percona/percona-xtradb-cluster-operator:1.11.0-logcollector imagePullPolicy: IfNotPresent resources: requests: cpu: 100m memory: 100M pmm: enabled: false proxysql: enabled: false pxc: affinity: antiAffinityTopologyKey: kubernetes.io/hostname autoRecovery: true gracePeriod: 600 image: percona/percona-xtradb-cluster:8.0.27-18.1 imagePullPolicy: IfNotPresent podDisruptionBudget: maxUnavailable: 1 resources: requests: cpu: 100m memory: 512Mi size: 3 volumeSpec: persistentVolumeClaim: resources: requests: storage: 512Mi updateStrategy: SmartUpdate upgradeOptions: apply: 8.0-recommended schedule: 0 4 * * * versionServiceEndpoint: https://check.percona.com

Now, remove this label from CR and apply it again:

apiVersion: pxc.percona.com/v1 kind: PerconaXtraDBCluster metadata: finalizers: - delete-pxc-pods-in-order name: test-cluster spec: haproxy: affinity: antiAffinityTopologyKey: kubernetes.io/hostname enabled: true gracePeriod: 30 image: percona/percona-xtradb-cluster-operator:1.11.0-haproxy imagePullPolicy: IfNotPresent podDisruptionBudget: maxUnavailable: 1 resources: requests: cpu: 100m memory: 512Mi size: 3 allowUnsafeConfigurations: false backup: image: percona/percona-xtradb-cluster-operator:1.11.0-pxc8.0-backup imagePullPolicy: IfNotPresent pitr: enabled: false schedule: - keep: 3 name: sat-night-backup schedule: 0 0 * * 6 storageName: s3-us-west - keep: 5 name: daily-backup schedule: 0 0 * * * storageName: fs-pvc storages: fs-pvc: type: filesystem volume: persistentVolumeClaim: accessModes: - ReadWriteOnce resources: requests: storage: 512Mi s3-us-west: s3: bucket: S3-BACKUP-BUCKET-NAME-HERE credentialsSecret: my-cluster-name-backup-s3 region: us-west-2 type: s3 verifyTLS: true crVersion: 1.11.0 enableCRValidationWebhook: true logcollector: enabled: true image: percona/percona-xtradb-cluster-operator:1.11.0-logcollector imagePullPolicy: IfNotPresent resources: requests: cpu: 100m memory: 100M pmm: enabled: false proxysql: enabled: false pxc: affinity: antiAffinityTopologyKey: kubernetes.io/hostname autoRecovery: true gracePeriod: 600 image: percona/percona-xtradb-cluster:8.0.27-18.1 imagePullPolicy: IfNotPresent podDisruptionBudget: maxUnavailable: 1 resources: requests: cpu: 100m memory: 512Mi size: 3 volumeSpec: persistentVolumeClaim: resources: requests: storage: 512Mi updateStrategy: SmartUpdate upgradeOptions: apply: 8.0-recommended schedule: 0 4 * * * versionServiceEndpoint: https://check.percona.com

Observe that the label key: value is not deleted from haproxy statefulset

Suspected Root Cause

The haproxy statefulset is reconciled mainly by the updatePod function. When the labels for the haproxy statefulset is updated, the function use label entries in CR to override the existing labels. Since the label to be deleted will not show up in CR, the user can never delete any labels.

Environment

Operating System: Ubuntu 20.04 LTS

Software Platform: kind@0.14.0

Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.2", GitCommit:"f66044f4361b9f1f96f0053dd46cb7dce5e990a8", GitTreeState:"clean", BuildDate:"2022-06-15T14:22:29Z", GoVersion:"go1.18.3", Compiler:"gc", Platform:"linux/amd64"}

Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.9", GitCommit:"6df4433e288edc9c40c2e344eb336f63fad45cd2", GitTreeState:"clean", BuildDate:"2022-05-19T19:53:08Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}

Smart Checklist

Activity

Details

Assignee

Reporter

Found by Automation

Yes

Needs Review

Yes

Needs QA

Yes

Affects versions

Priority

Smart Checklist

Created July 23, 2022 at 7:21 AM
Updated March 5, 2024 at 5:35 PM

Flag notifications