PMM Admin: missing inventory command in help

Description

User impact:

No help for inventory command in pmm-admin global command

Steps to reproduce:

Run pmm-admin --help

Actual result:

Missing inventory command in pmm-admin --help

beata@OSR-LAP-045:~/pmm2-client-2.31.0/bin$ ./pmm-admin -h Usage: pmm-admin <command>Version 2.31.0-HEAD-972aaa0fFlags:   -h, --help                          Show context-sensitive help.       --server-url=SERVER-URL         PMM Server URL in https://username:password@pmm-server-host/ format       --server-insecure-tls           Skip PMM Server TLS certificate validation       --debug                         Enable debug logging       --trace                         Enable trace logging (implies debug)       --pmm-agent-listen-port=7777    Set listen port of pmm-agent       --json                          Enable JSON output   -v, --version                       Show application versionCommands:   status        Show information about local pmm-agent   summary       Fetch system data for diagnostics   list          Show Services and Agents running on this Node   config        Configure local pmm-agent   annotate      Add an annotation to Grafana charts   unregister    Unregister current Node from PMM Server   remove        Remove Service from monitoring   register      Register current Node with PMM Server   add           Add Service to monitoring   version       Print versionRun "pmm-admin <command> --help" for more information on a command.

Missing command options in pmm-admin inventory --help

beata@OSR-LAP-045:~/pmm2-client-2.31.0/bin$ ./pmm-admin inventory -h Usage: pmm-admin inventory <command> Inventory commands Flags:   -h, --help                          Show context-sensitive help.       --server-url=SERVER-URL         PMM Server URL in https://username:password@pmm-server-host/ format       --server-insecure-tls           Skip PMM Server TLS certificate validation       --debug                         Enable debug logging       --trace                         Enable trace logging (implies debug)       --pmm-agent-listen-port=7777    Set listen port of pmm-agent       --json                          Enable JSON output   -v, --version                       Show application version Commands:

Expected result:

Commands:   status        Show information about local pmm-agent   summary       Fetch system data for diagnostics   list          Show Services and Agents running on this Node   config        Configure local pmm-agent   annotate      Add an annotation to Grafana charts   unregister    Unregister current Node from PMM Server   remove        Remove Service from monitoring   register      Register current Node with PMM Server   add           Add Service to monitoring   version       Print version inventory ??? explanation here
beata@OSR-LAP-045:~/pmm2-client-2.31.0/bin$ ./pmm-admin inventory -h Usage: pmm-admin inventory <command> Inventory commands Flags:   -h, --help                          Show context-sensitive help.       --server-url=SERVER-URL         PMM Server URL in https://username:password@pmm-server-host/ format       --server-insecure-tls           Skip PMM Server TLS certificate validation       --debug                         Enable debug logging       --trace                         Enable trace logging (implies debug)       --pmm-agent-listen-port=7777    Set listen port of pmm-agent       --json                          Enable JSON output   -v, --version                       Show application version Commands: add remove list ...

How to test

None

How to document

None

Smart Checklist

Activity

Show:

Alex Demidoff July 26, 2023 at 1:43 PM

Former user August 16, 2022 at 10:05 AM

do we really want to keep inventory command hidden? Should I close this as "won't fix"?

Michal August 16, 2022 at 7:40 AM

Not sure to be honest. I just see it's not a bug, but a feature slightly smiling face

Former user August 16, 2022 at 7:30 AM

Sorry, had no idea this is by design... Any idea why is it hidden?

Michal August 16, 2022 at 7:06 AM

This is expected since the "inventory" command is hidden by design.

Is there any specific reason you believe it shall be visible?

Won't Do

Details

Assignee

Reporter

Priority

Components

Needs QA

Yes

Needs Doc

Yes

Smart Checklist

Created August 15, 2022 at 3:15 PM
Updated July 26, 2023 at 1:43 PM
Resolved July 26, 2023 at 1:43 PM

Flag notifications