Looks like mechanism from PMM-8357 does not work with PMM-2.31.0

Description

User impact:

User can't supply arguments as files (for example credentials) to pmm-admin.

 

Steps to reproduce:

https://jira.percona.com/browse/PMM-8357

Actual result:

file argument is ignored.

Expected result:

this feature is not fully official, but was supported by kingpin and suggested in:

https://www.percona.com/blog/how-to-hide-credentials-from-percona-monitoring-and-management-client-commands/

 

Workaround:

none, but there would be a special flag:

https://jira.percona.com/browse/PMM-10231

 

Details:

We use the mechanism described in   to put all flags in a file and use that file in config/add command. This worked perfectly fine in 2.29.1, but seems not to work with 2.31.0. The flags file and its content gets ignored.

How to test

None

How to document

None

Smart Checklist

Activity

Show:

Denys Kondratenko October 7, 2022 at 7:56 AM

we switched from kingpin to kong: https://github.com/alecthomas/kong

duygu.aksoy October 7, 2022 at 6:37 AM

please plan it It was also reported by the user. Thank you

Aaditya Dubey October 6, 2022 at 3:03 PM
Edited

Hi ,

Thank you for the report.
Able to repeat the issue, Please find my test case below:

On PMM 2.29.1 :

On PMM 2.31.0 :

sending the concern to engineering for further review and updates.

duygu.aksoy October 6, 2022 at 11:59 AM

this is the issue that I forwarded via email

duygu.aksoy October 6, 2022 at 11:58 AM

Can we please confirm reported bug?  

It was also reported by a user

Duplicate

Details

Assignee

Reporter

Priority

Components

Needs QA

Yes

Needs Doc

No

Regression Issue

Yes

Affects versions

Smart Checklist

Created October 4, 2022 at 7:42 AM
Updated July 16, 2024 at 8:40 AM
Resolved October 19, 2022 at 11:14 AM