Update grafana.ini domain parameter on PMM Public Address setting change

Description

User impact:

User receives alert notifications that always contain link to localhost. We should provide valid link there.

 

Steps to reproduce:

 

Actual result:

 

Expected result:

 

Workaround:

set `domain = <address>` in grafana.ini or use `GF_SERVER_DOMAIN=<address>` environment variable 

 

Details:

Original issue: https://github.com/percona/pmm/issues/1823/

How to test

How to document

Previously, setting the PMM public address has no effect on the domain setting in grafana.ini and Grafana had no idea of the public address where PMM is running.

This caused Grafana-generated links to be broken (e.g in alerting emails).

With this change, changes made to the PMM public address are propagated to grafana.ini.

https://docs.percona.com/percona-monitoring-and-management/how-to/configure.html#public-address

100% Done
Loading...

Activity

Show:

saikumar.vs August 24, 2023 at 8:25 AM

verified, pls refer testcase section for more details.

saikumar.vs August 17, 2023 at 11:24 AM
Edited

with the lastest FB's i still not able to see the public IP updated in the ini file, it displays as         cfg:default.server.domain=""
 

Done

Details

Assignee

Reporter

Priority

Components

Needs QA

Yes

Needs Doc

Yes

Planned Version/s

Fix versions

Story Points

Smart Checklist

Created March 7, 2023 at 10:43 AM
Updated March 5, 2024 at 11:53 PM
Resolved October 5, 2023 at 12:14 PM