Allow tuning client-side vmagent process.

Description

We should allow modifying vmagent process configurations in use. In particular it will be needed for changing remoteWrite.maxDiskUsagePerURL, which is 1Gb by default in current PMM client versions:

This variable governs how much disk space can be used in the event of a disconnection with the server. It seems to be innocuous, but in the case were many PMM client instances are running sharing mountpoint for /tmp/, for example, it may cause issues. This is particularly true in k8s environments, where disk space is shared between many services.

 

How to test

None

How to document

VMAGENT_ env variables passed to PMM Server will be passed to all PMM Clients connected. How to create env variable to override flag is mentioned in this link

List of all available flags

AFFECTED CS IDs

CS0034681

Smart Checklist

hide

Activity

Show:

Nurlan Moldomurov July 17, 2024 at 9:35 AM

Hi , thank you for the message. We figured out that we left a few parameters hardcoded, so we changed type of this task from Doc to development task.

Nurlan Moldomurov December 7, 2023 at 11:18 AM

We have implemented support of vmagent tuning by passing VMAGENT_ env variables to PMM Server in scope of , but haven't properly documented yet. VMAGENT_ env variables passed to PMM Server will affect all PMM Clients connected.

Agustin Gallego May 1, 2023 at 8:37 PM
Edited

, I think it will suffice with it being global. If you want to make it per instance, we should also have a global setting which should be inherited by default, with the ability to be overwritten on a per-instance basis.

Edit: actually, I think I misunderstood your point. Did you mean global like we are using metrics resolution times now? Then no, I think it should be per instance/node. Ideally we should have it added as flag to `pmm-admin config`.

Nurlan Moldomurov April 28, 2023 at 8:46 PM

Hi do you want to make it configurable per instance or global?

Chetan Shivashankar March 27, 2023 at 4:33 PM

FYI

Details

Assignee

Reporter

Priority

Components

Needs QA

Yes

Needs Doc

Yes

Planned Version/s

Story Points

Affects versions

Smart Checklist Progress

Smart Checklist

Created March 21, 2023 at 1:53 AM
Updated November 4, 2024 at 2:29 PM