Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Comments are parsed by default for remotely added PostgreSQL and MySQL

Description

  1. Install PMM server 2.38.0

  2. Add Remote Postgres RDS and MySQL RDS with default disabled comments parsing option

  3. Connect to Postgres and execute the next query:
    select /* test='teest' */ 200;
    Connect to MySQL and execute query:
    select /* test='teest' */ 200;

  4. Wait for a few minutes

  5. Open QAN and select added Postgres and MySQL service

Actual result:  There are some new filters related to comments parsing:

Expected result: There is no new filters related to comments parsing

 

http://3.15.191.138/graph/d/pmm-qan/pmm-query-analytics?var-environment=All&var-cluster=All&var-replication_set=All&var-database=All&var-schema=All&var-node_name=All&var-service_name=All&var-client_host=All&var-username=All&var-service_type=All&var-node_type=All&var-city=All&var-az=All&var-interval=auto&columns=%5B%22load%22,%22num_queries%22,%22query_time%22%5D&group_by=queryid&order_by=-load&from=now-12h&to=now&page_number=1&page_size=25&totals=false&details_tab=details

How to test

  1. Add RDS PostgreSQL to monitoring.

  2. Go to inventory and open details for that RDS service.

  3. Here in details open details for “Qan postgresql pgstatements agent”

  4. You should see comments_parsing_disabled=true between labels. This means comment parsing is disabled like expected.

  5. Repeat same steps for MySQL, expect in details you will see “Qan mysql perfschema agent”. This agent should have comments_parsing_disabled=true label too.

  6. Go to QAN, run some queries with comments /* test='comment' */ etc and see that there is no filter based on comments in left panel.

How to document

None

Attachments

3
  • 05 Jul 2023, 10:38 AM
  • 05 Jul 2023, 10:38 AM
  • 05 Jul 2023, 09:28 AM

Activity

Show:
Done

Details

Assignee

Reporter

Priority

Components

Labels

Needs QA

Yes

Needs Doc

No

Planned Version/s

Fix versions

Story Points

Affects versions

Smart Checklist

Created July 5, 2023 at 10:14 AM
Updated March 5, 2024 at 10:18 PM
Resolved February 5, 2024 at 3:18 PM

Flag notifications