Update the MySQL Golang driver for MySQL 8 compatibility

Description

since
https://github.com/go-sql-driver/mysql/pull/794 is merged, can you update our code (feature build )
To see - is it working correctly with mysql8 or not.

After this - we'll understand how to release it (in current or next release )

How to test

None

How to document

None

relates to

Smart Checklist

Activity

Roma Novikov June 13, 2018 at 9:43 AM

All repos are updated. we should check pmm against mysql8 with defaults 

Kamil Dziedzic May 29, 2018 at 9:30 PM

Also until PT-1562 is release I've disabled pt-mysql-summary test for MySQL 8 in qan-agent.

Kamil Dziedzic May 29, 2018 at 9:17 PM
Edited

qan-agent test were failing with new go mysql driver from master, after using another patch from author tests pass https://github.com/go-sql-driver/mysql/pull/807#issuecomment-392755713

However, there is waiting another big patch https://github.com/go-sql-driver/mysql/pull/808

So I think at this point we should wait for new 1.4 release of driver.

Here is PR  to watch for release https://github.com/go-sql-driver/mysql/pull/809 and https://github.com/go-sql-driver/mysql/pull/808 is the only blocker.

 

Updated projects (but required to be updated again to 1.4)

https://github.com/percona/mysqld_exporter/pull/30

https://github.com/percona/qan-agent/pull/90

https://github.com/percona/pmm-client/pull/135

https://github.com/percona/pmm-managed/pull/48

 

Kamil Dziedzic May 21, 2018 at 8:35 PM

Done

Details

Assignee

Reporter

Priority

Components

Labels

Fix versions

Smart Checklist

Created May 21, 2018 at 8:03 AM
Updated July 11, 2018 at 5:25 PM
Resolved June 27, 2018 at 6:07 PM