Enable Textfile Collector by Default in node_exporter

Description

We should simplify enabling text file collector extensions for PMM user

We should enable it by default and create specific directory which is part
of the agent install where users simply can put text files from the scripts
they create


Peter Zaitsev, CEO, Percona

TODO
1) Implement automatic collection of *.prom text files from /usr/local/percona/pmm-client/textfile-collector by default making change in https://github.com/percona/node_exporter/blob/master/collector/textfile.go#L36
2) create /usr/local/percona/pmm-client/textfile-collector during installation of pmm-client
3) place to /usr/local/percona/pmm-client/textfile-collector file sample.prom with commented example and link to
https://github.com/prometheus/node_exporter#textfile-collector for usage and examples
4) ? add some tests to ensure this feature will work later

How to test

None

How to document

None

Smart Checklist

Activity

Nailya Kutlubaeva October 19, 2018 at 2:31 PM

tested

Evgeniy Patlan October 18, 2018 at 2:56 PM

fixed. thanks to for help!

Evgeniy Patlan October 18, 2018 at 1:29 PM

this issue is connected with broken push into repo. the package in repo is for  16th of October

Nailya Kutlubaeva October 18, 2018 at 9:52 AM

There is no such file on pmm-client path:

Michael Coburn October 10, 2018 at 12:23 AM

Done

Details

Assignee

Reporter

Priority

Components

Fix versions

Smart Checklist

Created August 30, 2018 at 9:33 PM
Updated November 13, 2024 at 9:46 AM
Resolved October 30, 2018 at 9:54 PM