Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Not possible to modifying list of collected metrics

Description

User impact: User cannot modify list of collected metrics

Steps to reproduce:

  1. Specify metric for exporter (node_exporter or mysql_exporter):

  2. Check logs.

Actual result:

Expected result: Eventswaits metric should be disabled

Additional information: It was found that there are 2 problems: the first one is node_exporter doesn't have option to disable default metrics, and the second is disabling default metrics doesn't work for mysqld_exporter

Original report:
Here is the result of my attempts of collecting only one collector diskstats.

How to test

None

How to document

None

AFFECTED CS IDs

245905

Smart Checklist

Activity

Nailya Kutlubaeva July 22, 2019 at 10:56 AM

works great!

Nailya Kutlubaeva July 10, 2019 at 8:42 AM

, the problem with textile_collector was fixed but the problem with disabling some collectors still exists (see my comment#https://jira.percona.com/browse/PMM-3256?filter=13309# )

Vadim Yalovets May 15, 2019 at 10:42 AM

I have done a rewind of submodules for PR-255 and commit with correct folder name has been processed. So pmm-client from FB PR-225 should work with the folder textfile_collector.

Nailya Kutlubaeva May 14, 2019 at 7:47 PM

I've just checked node_exporter from pmm-client from FB PR-225 and it has wrong name:

But pmm-client-1.17.2 from testing repository has correct name

I checked disabling metrics for node_exporter and it works ok for pmm-client from FB and doesn't work in pmm-client from testing repository.

But it seems I've found another problem: disabling metrics for mysql doesn't work (for both pmm-clients), for example, I disabled collect.perf_schema.eventswaits and collect.perf_schema.file_events :

mysql_exporter is started with passed options, but I checked metrics in PMM (/metrics-lr) and they are not disabled:

I re-checked again PMM 1.13.0 and when I run mysql_exporter with disabled these metrics :

But in PMM 1.13.0 all option are passed from command line were added in the end of command, so mysqld_exporter uses the latest specified options, not default options.

Vadim Yalovets May 14, 2019 at 3:45 PM


Could you check if the correct version of node_exporter was tested?
I have just tested files from https://repo.percona.com/testing/latest/SRPMS/pmm-client-1.17.2-1.src.rpm
and exporter is checking file /usr/local/percona/pmm-client/textfile_collector

Done

Details

Assignee

Reporter

Priority

Components

Labels

Fix versions

Affects versions

Smart Checklist

Created November 13, 2018 at 1:32 PM
Updated July 18, 2024 at 2:22 PM
Resolved July 22, 2019 at 10:56 AM