supervisior PID file in /tmp

Description

The PID file is normally under /run but is found in /tmp.

How to test

None

How to document

None

Smart Checklist

Activity

C W October 16, 2019 at 10:40 AM

The file (socket) for supervisord is, as expected, in /var/run/supervisor.. the pidfile is in /tmp

Leaving files in /tmp relating to a build is also not great.

If it were in the standard location, which is still configured in /etc/supervisord.conf, there would be no confusion and less to change when fixing the container so that it does not run processes as root

Alexey Palazhchenko October 16, 2019 at 9:55 AM

Sorry, but I still don't understand you. File permissions is a separate issue. This ticket is about the usage of /tmp instead of /run. Is there anything that prevents you from changing permissions on /tmp/supervisord.pid that would work on /run/supervisord.pid?

PID file location was changed by : https://github.com/percona/pmm-server/pull/92/files#diff-1c132cd2582dfc6eee14e5064b7fbd4fR10 Probably he can explain why he made this change.
We still use the same path in 2.x: https://github.com/percona/pmm-server/blob/d35b429475ec8d9d0799c5b6ca28134b171e2252/supervisord.conf#L8

C W October 16, 2019 at 9:36 AM

We support the rootless container in MS and were forced to manage permissions on /tmp/supervisord.pid because it is present and owned by root in the container:

Mounted PMMv1 container

It appears that you have stopped this happening in 2.x:

Mounted PMMv2 container

Please explain why the default path was changed in the first place.

Alexey Palazhchenko October 16, 2019 at 7:27 AM

I read it before commenting. I still do not understand why the usage of /tmp instead of /run is a problem.

C W October 16, 2019 at 7:24 AM

please read the ticket that this triggers

Done

Details

Assignee

Reporter

Priority

Components

Affects versions

Smart Checklist

Created February 14, 2019 at 6:31 PM
Updated March 6, 2024 at 6:28 AM
Resolved November 17, 2022 at 2:42 PM