Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Linux kernel 4.18 breaks diskstats parse

Description

uname -r
4.18.0-80.el8.x86_64

cat /proc/diskstats
8 0 sda 14288 352 1383982 66408 2159019 1630468 604273712 2988406 0 404591 2382392 0 0 0 0
8 1 sda1 28 0 224 37 0 0 0 0 0 16 31 0 0 0 0
8 2 sda2 246 0 54082 2746 94 11 29920 31 0 97 2678 0 0 0 0
8 3 sda3 13042 352 1294554 59737 178302 68409 3440912 43945 0 27318 61083 0 0 0 0
8 4 sda4 867 0 30554 3714 1980623 1562048 600802880 2944429 0 383416 2318445 0 0 0 0
11 0 sr0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

 

log of node_exporter

/usr/sbin/node_exporter -web.listen-address=:9100 -collectors.enabled=diskstats,filefd,filesystem,loadavg,meminfo,netdev,netstat,sockstat,stat,time,uname,vmstat,meminfo_numa,textfile,ipvs,tcpstat -collector.textfile.directory=

Jul 03 23:46:45 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:46:45+08:00" level=error msg="ERROR: diskstats collector failed after 0.000263s: invalid line for /proc/diskstats for sda" source="node_exporter.go:97"
Jul 03 23:47:15 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:47:15+08:00" level=error msg="ERROR: diskstats collector failed after 0.000367s: invalid line for /proc/diskstats for sda" source="node_exporter.go:97"
Jul 03 23:47:45 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:47:45+08:00" level=error msg="ERROR: diskstats collector failed after 0.000169s: invalid line for /proc/diskstats for sr0" source="node_exporter.go:97"
Jul 03 23:48:15 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:48:15+08:00" level=error msg="ERROR: diskstats collector failed after 0.000232s: invalid line for /proc/diskstats for sr0" source="node_exporter.go:97"
Jul 03 23:48:45 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:48:45+08:00" level=error msg="ERROR: diskstats collector failed after 0.000221s: invalid line for /proc/diskstats for sr0" source="node_exporter.go:97"
Jul 03 23:49:15 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:49:15+08:00" level=error msg="ERROR: diskstats collector failed after 0.001161s: invalid line for /proc/diskstats for sr0" source="node_exporter.go:97"
Jul 03 23:49:45 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:49:45+08:00" level=error msg="ERROR: diskstats collector failed after 0.000414s: invalid line for /proc/diskstats for sda" source="node_exporter.go:97"
Jul 03 23:50:15 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:50:15+08:00" level=error msg="ERROR: diskstats collector failed after 0.000312s: invalid line for /proc/diskstats for sda" source="node_exporter.go:97"
Jul 03 23:50:45 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:50:45+08:00" level=error msg="ERROR: diskstats collector failed after 0.000242s: invalid line for /proc/diskstats for sda" source="node_exporter.go:97"
Jul 03 23:51:15 online-node-90-56 node_exporter[3683]: time="2019-07-03T23:51:15+08:00" level=error msg="ERROR: diskstats collector failed after 0.000249s: invalid line for /proc/diskstats for sr0" source="node_exporter.go:97"

 

I saw the pr https://github.com/percona/node_exporter/pull/11, I have updated pmm-client to 1.17.1, but the issue still exists.

How to test

None

How to document

None

Smart Checklist

Activity

Nurlan Moldomurov July 24, 2024 at 10:19 PM

Closing because PMM 1 is reached EOL

Gordan Bobic May 2, 2021 at 11:46 AM

Here is a link to the backported patch for node_exporter version used in PMM 1.x:

https://github.com/shatteredsilicon/node_exporter/commit/cb2dd588eaadf44b53e51a932d44105ea5c14881

 

Roma Novikov November 25, 2019 at 8:59 PM

Hi . The  PR you  see is  for PMM2 (see the branch we merged this PR)

For PMM2  we upgraded node_exporter.  This update has several breaking changes so it will be very hard to do (backport) this to pmm1

You  can see short adnvantages overview of PMM2  at https://www.percona.com/blog/2019/09/19/percona-monitoring-and-management-pmm-2-ga-is-now-available/

Won't Do

Details

Assignee

Reporter

Priority

Components

Labels

Needs QA

Yes

Needs Doc

Yes

Affects versions

Upstream Bug URL

https://github.com/prometheus/node_exporter/issues/1049

Smart Checklist

Created July 3, 2019 at 8:07 AM
Updated July 24, 2024 at 10:19 PM
Resolved July 24, 2024 at 10:19 PM

Flag notifications