PMM Upgrade from old 2.x versions to 2.2.0 shows Grafana Update Error and needs a manual refresh

Description

On trying to Upgrade from PMM 2.x (old version) to PMM 2.2.0 when the users click on `OK`  button on successful update popup as soon as it appears, we have this race condition, and on reload we see a Grafana update error. 

This error is caused because "pmm-update / pmm-managed part does not expect that Grafana will be restarted by dashboards upgrade script"

Current workaround to this problem is to click on Reload button or refresh the page and the update works fine. 

 

To test it:

  • replace version inside /srv/grafana/PERCONA_DASHBOARDS_VERSION with some previous like 2.0.0;

  • run supervisorctl tail -f dashboard-upgrade;

  • alt+click on update button to force update process;

  • log window should stay on screen for a few seconds and wait for dashboard-upgrade to finish;

  • check dashboard-upgrade logs.

How to test

None

How to document

None

Attachments

2

Smart Checklist

Activity

Puneet Kala December 26, 2019 at 7:21 AM

I have verified Upgrade from 2.2.0, 2.1.0 and 2.0.1 along with force update for this, It seems to be working fine, the change for wait on Grafana Dashboard to upgrade are also visible on Log, hence moving this issue to In Doc Now. 

 

Done

Details

Assignee

Reporter

Priority

Components

Needs QA

Yes

Needs Doc

Yes

Fix versions

Story Points

Sprint

Affects versions

Smart Checklist

Created December 25, 2019 at 10:12 AM
Updated March 6, 2024 at 5:02 AM
Resolved January 23, 2020 at 3:48 PM