Docker container for `pmm-client`: Option to change behavior and follow sidecar pattern

Description

This improvement request comes from this bug: https://jira.percona.com/browse/K8SPXC-585

Issue:

If pmm-client cannot connect to pmm-server for any reason (network glitch, wrong password), pmm-client container crashes.

This means that monitoring server stability can affect the stability of the database cluster.

Desired behavior:

Container should not crash, but just throw an error.

Good example - mongodb-exporter. If it cannot connect to MongoDB database:

  • it still runs

  • on metrics page it tells that it cannot connect to MongoDB and states the reason

Default entrypoint shouldn't exit with error, but waiting in infinite loop with trying to apply failed commands and provide logs to show issue.

How to test:

 

How to test

None

How to document

None

Attachments

2

Smart Checklist

Activity

Show:

Roma Novikov November 30, 2021 at 9:59 PM

,  can we have +2 lines in our documentation https://www.percona.com/doc/percona-monitoring-and-management/2.x/setting-up/client/index.html#docker to explain the flags. 

thanks  

Nurlan Moldomurov October 13, 2021 at 12:05 PM

For failed API tests we created separate task  

Sergey Pronin October 5, 2021 at 8:56 AM

It is in PG 1, yes.

Roma Novikov October 4, 2021 at 9:41 PM

, isn't this something already used in PG operator 1.0.0 ? 

Nurlan Moldomurov October 4, 2021 at 9:29 AM

 those tests are not related to changes made in this PR at all.

Done

Details

Assignee

Reporter

Priority

Components

Needs QA

Fix versions

Story Points

Smart Checklist

Created March 10, 2021 at 1:29 PM
Updated April 15, 2025 at 10:19 AM
Resolved December 15, 2021 at 1:52 PM