Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Integrated Alerting: New notification channel added: Webhooks

Description

Add WebHook to Notification Channels on Integrated Alerting UI

Acceptance Criteria:
There is one new WebHook notification Channel in Integrated Alerting>>>Notification Channels section.
Users can choose the channel, specify WebHook URL value from the application he wants to send data to and create a new WebHook Notification Channel.
Notifications for alerts with WebHook notification channels are sent to this channel.

How to test

None

How to document

None
100% Done
Loading...

Smart Checklist

Activity

Show:

vasyl.yurkovych November 1, 2021 at 4:59 PM

verified in perconalab/pmm-server-fb:PR-2034-bcbdc31 FB

Fábio Da Silva October 28, 2021 at 8:38 AM

 It was decided that the third point will be addressed in a different ticket.

I've implemented the other two points. As for the TLS clarifications: if we merge https://github.com/percona-platform/core-ui/pull/27 in the meanwhile, we can then use the tooltips here as well

Zoriana Stefanyshyn October 26, 2021 at 7:06 PM

WebHook channel modal with current implementation contains some inconsistencies:

  1. Based on documentation from Alertmanager there is an <http_config> which sets the `Authorization` header with the configured data. So I would  rename this section called currently ‘Authentication Type’ to Authorization Type and add also No Auth as WebHook also allows to send  unauthorized requests (insecure way of sending webhooks)

  2. Additionally, I would suggest adding <tls_config> as a separate section with some checkbox and open it only after the user clicks on the checkbox (wants to enable TLS configs). Also, we could add some clarifications for TLS configs like this in docs https://prometheus.io/docs/alerting/0.21/configuration/#webhook_config.

  3. Our backend implementation also allows adding file paths for TLS configs. On UI should be also a way to do this.

 Moving back ticket In Progress

 
CC:

Zoriana Stefanyshyn October 18, 2021 at 9:40 AM

 could you please check failing tests?

Fábio Da Silva August 19, 2021 at 9:47 AM

Done

Details

Assignee

Reporter

Priority

Components

Labels

Needs QA

Needs Doc

Fix versions

Story Points

Parent

Smart Checklist

Created May 4, 2021 at 12:27 PM
Updated March 6, 2024 at 2:47 AM
Resolved November 24, 2021 at 8:16 AM