Support --collector.COLLECTOR for mongodb_exporter
General
Escalation
General
Escalation
Description
How to test
None
How to document
None
Smart Checklist
Activity
Show:
Denys Kondratenko December 3, 2021 at 8:29 AM
oops, everything is merged.
Denys Kondratenko December 3, 2021 at 8:26 AM
changes are still under review.
Carlos Salguero November 30, 2021 at 7:01 PM
Already updated for
Roma Novikov October 18, 2021 at 5:54 PM
Until we describe the Improvement for PMM users - this is an Admin task as we are just adding more tech stuff, not user value
I'm thinking about https://github.com/prometheus/node_exporter#filtering-enabled-collectors, and ... we probably need this option too. So, can we start Exporter with all parameters and add or remove it to the request based on the flag?
Done
Details
Details
Assignee
Unassigned
UnassignedReporter
Nurlan MoldomurovPriority
MediumComponents
Labels
Needs QA
Yes
Fix versions
Story Points
0.5
Smart Checklist
Open Smart Checklist
Smart Checklist
Open Smart Checklist
Created October 18, 2021 at 12:19 PM
Updated November 13, 2024 at 9:45 AM
Resolved December 3, 2021 at 8:31 AM
User Story:
Once https://github.com/percona/mongodb_exporter/issues/358 is implemented we should start supporting new flag names `–colector.COLLECTOR` and `--no-collector.COLLERTOR` in newer versions of mongodb_exporter and support old flag names for old pmm clients.
This is to make the mongodb_exporter follow the Prometheus community way to enable/disable collectors.
UI/UX
None
Suggested implementation
Modify the exporter flags (already done in PR #365)
Update the parameters pmm-managed sends to the exporter.
Acceptance criteria:
Old pmm clients still works with new PMM Server
New pmm clients(with latest mongodb_exporter) works