Can't change PMM Advanced Settings if data retention is set through environment

Description

User impact:

user can't enable features or set any "Advanced Settings" if Data retention is set with help of environment variable.

Steps to reproduce:

set environment variable for pmm:

DATA_RETENTION="360h" # 15 days

login to pmm, go to Settings->Advanced settings

try to change any parameter, like DBaaS enablement, or Public Address. Hit Apply changes.

 

Actual result:

no changes to the settings applied, error displayed.

 

Expected result:

Error should appear only when field that was mandated by env variable is changed. 

Settings unrelated to the dictated by env should be changed.

 

Ability to set Public address and other advanced settings.

 

Workaround:

remove env variable setting.

Details:

How to test

None

How to document

None

Attachments

1
  • 01 Apr 2022, 06:49 PM

Activity

Roma Novikov 
April 5, 2022 at 8:41 AM

Puneet Kala 
April 5, 2022 at 5:25 AM

Roma Novikov 
April 4, 2022 at 7:54 PM

( then this is a serious problem. 
 PTAL .

I'm changing priority here and adding to 2.28 scope. 

Denys Kondratenko 
April 4, 2022 at 1:42 PM

 I am not sure it could be days:

https://pkg.go.dev/time#ParseDuration : Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".

> ERRO[2022-04-04T13:38:03.995+00:00] Configuration error: environment variable "DATA_RETENTION=15d" has invalid duration 15d.

Roma Novikov 
April 4, 2022 at 7:59 AM

This might be because UI is trying to send a converted value (15d) instead of  '360h' in Env.Var. 
, can you test this if you set '15d' in DATA_RETENTION.

Based on the result of this test, we can proceed with the issue based on priority and possible workarounds.

Duplicate

Details

Assignee

Reporter

Priority

Components

Needs QA

Needs Doc

Affects versions

Created April 1, 2022 at 6:50 PM
Updated March 6, 2024 at 1:23 AM
Resolved April 5, 2022 at 8:42 AM

Flag notifications