PSTRESS_BIN defaults to ps binary in pstress-run.conf

Description

The PSTRESS_BIN value remains the default as ps binary in pstress-run.conf, even if it is compiled for mysql versions:

PSTRESS_BIN=${SCRIPT_PWD}/../src/pstress-ps

This should be set to pstress-ms for mysql versions after compilation is completed. A better way would be to create a link to the pstress-ps/ms binary like:

lrwxrwxrwx 1 manish.chawla percona       10 Jul 29 14:34 pstress-latest -> pstress-ms

and then use this in PSTRESS_BIN

PSTRESS_BIN=${SCRIPT_PWD}/../src/pstress-latest

This way we would not have to change the pstress-run.conf, if we compile the pstress binaries with different MS/PS versions.

Environment

None

Smart Checklist

Activity

mohit.joshi July 29, 2022 at 3:45 PM

The idea of introducing different configuration files was based on the logic that each product has its own features/limitations and with the help of product specific configuration files we can set the parameters before starting a run.

The driver script expects from the user to provide configuration file specific to the product eg. 
For PS , we use pstress-run.conf
For PXC, we use pstress-run-PXC80.conf 

Ideally we should use a different configuration file for MS eg. pstress-run-MS.conf. But, the reason we do not have it in the repository is because PS is a derivate of MS and functionality wise both works the same, so we just points the PSTRESS_BIN to "pstress-ms" and re-use the same configuration file pstress-run.conf

Another issue I see is for eg:
A user may wish to use the same source code to compile and generate binaries for all 3 products 
pstress-ms, pstress-ps and pstress-pxc and place it in the same src directory and based on configuration file use them to do the runs.

Creating a softlink during compilation would involve making changes in the cmake files which will mean that we cannot use the same code to generate binaries for different product at the same time as the new softlink would replace the previous binary.

IMHO I do not consider this is as a BUG. 

Won't Do

Details

Assignee

Reporter

Time tracking

30m logged

Priority

Smart Checklist

Created July 29, 2022 at 12:48 PM
Updated March 6, 2024 at 5:52 PM
Resolved August 1, 2022 at 9:33 AM

Flag notifications