LP #1130994: pt-query-advisor gives false, inconsistent warnings.

Description

**Reported in Launchpad by Tramada Systems last update 19-03-2013 23:33:10

Command: pt-query-advisor /tmp/sample4pt-query-advisor
Tools version: 2.1.9-1
MySQL version: 5.5.12
Output:
ALI.001 0xD6277F8BD92F2849

RES.002 0xD6277F8BD92F2849

  1. Profile

  2. Query ID NOTE WARN CRIT Item

  3. ================== ==== ==== ==== ==========================================

  4. 0xD6277F8BD92F2849 1 1 0 select this_.booking_id as booking???, ... from consultant this left outer join consultant consultant?_ on this_.default_buddy_consultant_id=consultant?.consultant_id inner join branch branch? on this_.lvl?branch_id=branch?.branch_id left outer join branch branch?_ on branch?.parent_branch_id=branch?.branch_id inner join role role?_ on this_.role_id=role?_.role_id

RES.002 is incorrectly reported for the last one out of three queries in attached sample file. Actually none of these queries has LIMIT clause, although word "limit" is a part of some column names.

Furthermore, testing with six subset files containing:

  • single query per file

  • two queries per file (1+2, 1+3, 2+3)

resulted in:

  • NO warnings from single query files

  • RES.002 from 1+2 file

  • CLA.001 from 1+3 and 2+3 files

CLA.001 warnings are correct as the third query does not have WHERE clause.

Environment

None

Smart Checklist

Activity

Show:

lpjirasync January 24, 2018 at 7:18 PM

**Comment from Launchpad by: Tramada Systems on: 19-03-2013 23:33:09

Reported behaviour was detected whilst processing large "long queries" logs files and was replicated processing attached sample file.
As reported above, running query-advisor against single queries looks to be giving correct advice.

lpjirasync January 24, 2018 at 7:18 PM

**Comment from Launchpad by: Daniel Nichter on: 13-03-2013 15:28:51

We have decided to remove pt-query-advisor from 2.2 and refocus our efforts on the online version of the tool: https://tools.percona.com/query-advisor. The attached file is a little difficult to make sense of because the queries are so large and seem to run together. Could you isolate the particular issues and report them at https://github.com/percona/query-advisor/issues please? Also, this means that any fixes for these queries will not be in the command line tool but rather the online tool.

Won't Do

Details

Assignee

Reporter

Priority

Smart Checklist

Created January 24, 2018 at 7:18 PM
Updated February 3, 2018 at 11:12 PM
Resolved January 24, 2018 at 7:18 PM