Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

add --output=secure-slowlog option to pt-query digest

Description

Add the option --output=secure-slowlog to pt-query-digest to replace the queries in the output by their fingerprints.

Environment

None

Attachments

2

Smart Checklist

Activity

Show:

Tomislav Plavcic March 16, 2018 at 9:11 AM

Review option is not connected to output option so I don't think this is relevant.

Tomislav Plavcic March 15, 2018 at 3:48 PM

The "–review" option will save unsanitized sample queries with data into destination server even if we specify "--output=secure-slowlog" - to be honest I have no clue if it's a requirement or not and even if it makes sense, example:

Tomislav Plavcic March 15, 2018 at 11:48 AM

As discussed the report part contains unsanitized data, if we skip report generation with "--no-report" it seems fine.

Tomislav Plavcic March 15, 2018 at 10:53 AM


I still see some queries with data even when using "--output=secure-slowlog" option, but I'm not sure if those queries should be like that or not - most probably not.

Slowlog: 

"./pt-query-digest --output=secure-slowlog slow.log" output: 

line 181 has this:

Done

Details

Assignee

Reporter

Priority

Components

Affects versions

Fix versions

Time tracking

1d 13m logged

Smart Checklist

Created March 12, 2018 at 5:50 PM
Updated March 19, 2018 at 1:58 PM
Resolved March 19, 2018 at 1:58 PM