Do not include superfluous files in distributable tar.gz

Description

Hi,
I've detected some superfluous files included in the distributable .tar.gz provided at https://www.percona.com/downloads/percona-toolkit/LATEST/

At version 3.0.7 those files are:

  • .git (superflous)

  • .gitignore (superflous)

  • .travis.yml (superflous)

  • util/mysql_random_data_loader_linux_amd64 (no source code provided)

  • util/version_cmp (no source code provided)

Please, consider the removal of superfluous files from .tar.gz file. This also will make a huge difference on the resulting distributable file:

Including these files produces:
rw-rr- 1 debuser debgroup 79294306 Mar 14 15:17 percona-toolkit-3.0.7.tar.gz

Without these files produces:
rw-rr- 1 debuser debgroup 14704469 Mar 14 15:18 percona-toolkit-3.0.7.tar.gz

Each time I prepare a new release for Debian, I have to repack the tar.gz to remove those files...

Thoughts?

Thanks in advance.

As a referece, I paste bits of my debian/changelog file:
---%<------------------------------------------------------------

percona-toolkit (3.0.7+dfsg-1) unstable; urgency=medium

  • New upstream release (3.0.7)

  • Repack original tarball to remove some files and dirs:

  • .git

  • .gitignore

  • .travis.yml

  • util/mysql_random_data_loader_linux_amd64

  • util/version_cmp
    ...

percona-toolkit (3.0.6+dfsg-1) unstable; urgency=medium

  • New upstream release (3.0.6)

  • Repack original tarball to remove some files and dirs:

  • .git

  • .gitignore

  • .travis.yml

  • util/mysql_random_data_loader_linux_amd64
    ...

percona-toolkit (3.0.5+dfsg-1) unstable; urgency=medium

  • New upstream release (3.0.5)

  • Repack original tarball to remove some files and dirs:

  • .git

  • .gitignore

  • .travis.yml
    ...

percona-toolkit (3.0.4+dfsg-1) unstable; urgency=medium

  • New upstream release (3.0.4)

  • Repack original tarball to remove some files and dirs:

  • .git

  • .gitignore
    ...

percona-toolkit (3.0.3+dfsg-1) unstable; urgency=medium

  • New upstream release (3.0.3)

  • Repack original tarball to remove some files and dirs:

  • .git

  • .gitignore

  • config/deb/control.bak

  • config/rpm/percona-toolkit.spec.bak
    ...

percona-toolkit (3.0.2+dfsg-1) unstable; urgency=medium

  • New upstream release (3.0.2)

  • Repack original tarball to remove .git metadata (.git directory
    and .gitignore file)
    ...

---%<------------------------------------------------------------

Environment

None

Smart Checklist

Activity

Tomislav Plavcic April 20, 2018 at 7:49 AM

".travis.yml" is still part of source tarball, anyway I have some other concerns about the naming for our debian source packages since in the downloads webpage they are listed together with general source tarballs and now they have the same name so there might be a conflict but I'm not 100% sure how it will look.

Let's leave this now as it is since there's no time and check more for the next release which I believe will be soon.

Evgeniy Patlan April 19, 2018 at 12:18 PM

fixed

Tomislav Plavcic April 19, 2018 at 7:16 AM

This is not resolved. Git history is still part of source tarball as well as ".gitignore", ".travis.yml".

util/mysql_random_data_load binary is still part of source tarball

Evgeniy Patlan March 26, 2018 at 8:18 AM

I have updated jenkins job to exclude files from source tarball as it was requested

Tomislav Plavcic March 14, 2018 at 5:35 PM

Confirmed that 3.0.7 source tarball includes the whole git tree and binary files "util/mysql_random_data_loader_linux_amd64" and "util/version_cmp".

Done

Details

Assignee

Reporter

Priority

Components

Affects versions

Fix versions

Time tracking

6h 40m logged

Smart Checklist

Created March 14, 2018 at 3:03 PM
Updated March 4, 2024 at 4:35 PM
Resolved March 26, 2018 at 8:19 AM

Flag notifications