Pt-query-digest not hiding parameter properly sometimes when parameter=binary

Description

I have attached a couple examples that when parsed with pt-query-digest will generate the following output:

 

buggy output:

non buggy:

{"classes":

It can be seen that on bugged version "contact_id" has a value, whereas on non bugged , parameter shown is "?".

 

Command used for parsing file is:

 

 

Environment

None

AFFECTED CS IDs

CS0013212

Attachments

2

Smart Checklist

Activity

Show:

Sveta Smirnova May 25, 2021 at 2:06 PM

Reason for this bug is this code in sub fingerprint:

It does not care if escaped quoted is in the end of the argument or not. However, slow query log can easily contain records like:

Sveta Smirnova May 25, 2021 at 12:01 PM

Reason for this bug is double slash in the end of the search string. It will be repeatable with any query like:

However for

It generates:

which is even worse.

Jira Bot March 29, 2021 at 11:56 AM

To:
CC:

Hi, I'm jira-bot, Percona's Jira automation tool. I've detected that someone from
Percona has made an edit to the Summary field of an issue that you reported.

I'm not sentient (yet) so I'm not sure whether the person fixed a typo, changed
a few words, or completely rewrote the text. In any case, it is Percona Engineering's
intention to make the Summary and Description of an issue as accurate as possible
so that we're fixing the actual problem you're encountering, and to avoid
misunderstandings about symptoms and causes.

If the current Summary does not accurately reflect the problem you are reporting,
or if you feel the change was otherwise inappropriate in some way, please add a
new comment explaining things and we'll address it as soon as we can.

This message will be added only once per issue, regardless of how many times
the Summary is edited.

message-code:summary-edited

Carlos Salguero October 20, 2020 at 12:41 PM

Having a clear way to reproduce it, I think it is enough.
I can write instructions for QA after working on this ticket.

Carlos Tutte October 19, 2020 at 4:00 PM

As per Sveta's request am providing the exact steps for reproducing:

 

 

 

 

Then check file content (output is large), but pay attention to ~2nd line where it says:

 

On bugged case:

 

On non bugged case:

 

Done

Details

Assignee

Reporter

Priority

Affects versions

Fix versions

Needs Review

Yes

Story Points

Sprint

Smart Checklist

Created October 15, 2020 at 9:52 PM
Updated February 29, 2024 at 8:56 PM
Resolved September 2, 2021 at 9:32 AM