Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Fix tests for pt-config-diff

Description

How to Repeat

Results are for https://perconadev.atlassian.net/browse/PS-8#icft=PS-8.0.30

$ prove -vw --trap --timer t/pt-config-diff/ [16:52:59] t/pt-config-diff/basics.t ..... ok 1 - Server active config doesn't differ with itself ok 2 - No output when no diff ok 3 - Exit 1 when diffs found ok 4 - Diff output not ok 5 - my.sandbox.cnf doesn't differ with active config # Failed test 'my.sandbox.cnf doesn't differ with active config' # at t/pt-config-diff/basics.t line 90. # got: '1' # expected: '0' not ok 6 - No output # Failed test 'No output' # at t/pt-config-diff/basics.t line 96. # got: '1 config difference # Variable /tmp/12345/my.sandbox.cnf Delly-7390 # ========================= ========================= ========== # innodb_buffer_pool_size 16777216 2147483648 # ' # expected: '' ok 7 - Master my.sandbox.cnf differs from slave active config ok 8 - Config diff output ok 9 - Server option file config doesn't differ with itself ok 10 - No output ok 11 - Master and slave option files differ ok 12 - Config diff output ok 13 - Case-insensitive by default, finds no diffs ok 14 - With case-insensitivity turned off, finds one diff ok 15 - Sandbox servers 1..15 # Looks like you failed 2 tests of 15. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/15 subtests [16:53:01] t/pt-config-diff/customize.t .. 1..2 ok 1 - port is different ok 2 - port is ignored ok 410 ms ( 0.01 usr 0.00 sys + 0.35 cusr 0.05 csys = 0.41 CPU) [16:53:01] t/pt-config-diff/pxc.t ........ 1..0 # SKIP PXC tests skipped: PXC tests [16:53:02] t/pt-config-diff/reports.t .... 1..3 ok 1 - Diff but no report ok 2 - Diff but not output because --no-report ok 3 - Sandbox servers ok 1930 ms ( 0.00 usr 0.00 sys + 0.68 cusr 0.40 csys = 1.08 CPU) [16:53:04] Test Summary Report ------------------- t/pt-config-diff/basics.t (Wstat: 512 Tests: 15 Failed: 2) Failed tests: 5-6 Non-zero exit status: 2 Files=4, Tests=20, 5 wallclock secs ( 0.03 usr 0.01 sys + 1.96 cusr 0.92 csys = 2.92 CPU) Result: FAIL

Suggested Fix

Identify which tests fail, because badly written and which show real issues with code, fix either tests or code.

Environment

None

Activity

Show:

Sveta Smirnova February 13, 2023 at 10:02 AM

I cannot repeat it with current trunk.

Cannot Reproduce

Details

Assignee

Reporter

Priority

Affects versions

Needs QA

Yes

Story Points

Smart Checklist

Created January 6, 2023 at 1:53 PM
Updated February 29, 2024 at 8:42 PM
Resolved February 13, 2023 at 10:02 AM