Allow pt-stalk do disable ps-lock-transactions data collection via parameter

Description

Data collection for ps-locks-transactions is the one below:

pt-stalks only dump this information when it is enabled: https://github.com/percona/percona-toolkit/blob/f0fea40da82589f1d23c66eebb127eed7c8df5b3/bin/pt-stalk#L1005-L1007
  

The workaround is to comment on the section. For example:

We get the following line in our pt-stalk output file and the ps-lock-transactions files are not created:

 

Environment

None

AFFECTED CS IDs

CS0041887

Activity

Show:

Leonardo Bacchi Fernandes November 27, 2023 at 5:47 PM

It might be a good idea to have one parameter that we can use to skip any data collected. For example: --skip-collection=ps-lock-transactions,global-variables. This is interesting for cases where pt-stalk may cause issues with certain data collections. There are some versions with known bugs that may cause the server to lockup by querying variables_by_thread (https://jira.percona.com/browse/PS-7250), or show full processlist (https://jira.percona.com/browse/PS-8683). In those cases, we usually resort to collecting the data manually through queries, but it would be nice if we could use pt-stalk with a --skip-collection parameter.

Details

Assignee

Reporter

Priority

Affects versions

Fix versions

Needs QA

Yes

Smart Checklist

Created November 27, 2023 at 4:19 PM
Updated November 15, 2024 at 1:29 PM