Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

LP #1042729: pt-table-checksum --quiet doesn't disable --check-plan warnings

Description

**Reported in Launchpad by Baron Schwartz last update 30-10-2012 22:13:14

I'm running pt-table-checksum from cron, and I only want output if there are differences. (Cron sends me email with any output.) Right now I'm seeing a lot of warnings from --no-check-plan. I believe this code should be changed:

7987 # Ensure that MySQL is still using the entire index.
7988 # https://bugs.launchpad.net/percona-toolkit/+bug/1010232
7989 if ( !$nibble_iter->one_nibble()
7990 && $tbl->{key_len}
7991 && ($expl->{key_len} || 0) < $tbl->{key_len} ) {
7992 if ( !$tbl->{warned}->{key_len}++
7993 && $o->get('quiet') < 2 ) {

The last line there should say "! $o->get('quiet')" in my opinion. I'm not worried if an occasional chunk is skipped.

Environment

None

Smart Checklist

Activity

lpjirasync January 24, 2018 at 3:54 PM

**Comment from Launchpad by: Daniel Nichter on: 30-10-2012 22:12:31

The code is ok as-is, or at least can't be changed in stable 2.1 because doing so would amount to either re-defining --quiet or having this special case. Some time ago we decided (and this is the documented and actual behavior):

no --quiet = full output, i.e. everything
--quiet = only errors, warnings, and tables with diffs, i.e. "show me what's important"
--quiet --quiet = only errors, i.e. using ptc in a script so caller can check ptc's exit status

Furthermore, warnings are only 1 per table to prevent flooding (e.g.

😉

lpjirasync January 24, 2018 at 3:54 PM

**Comment from Launchpad by: Sheeri K. Cabral on: 29-08-2012 15:35:37

How does pt-table-checksum know if it's skipping an occasional chunk or a sizeable amount of chunks?

Folks using pt-table-checksum expect every chunk to be checked, and if not, a warning is raised. If the behavior is changed, make sure to make that clear on the docs, that some chunks may be skipped silently in some cases.

Won't Do

Details

Assignee

Reporter

Priority

Labels

Smart Checklist

Created January 24, 2018 at 3:54 PM
Updated February 4, 2018 at 1:33 AM
Resolved January 24, 2018 at 3:54 PM

Flag notifications