LP #820104: pt-query-digest --[no]zero-bool doesn't work
Description
Environment
Smart Checklist
Activity

lpjirasync January 24, 2018 at 5:05 PM
**Comment from Launchpad by: Daniel Nichter on: 12-06-2012 00:44:50
This option has been removed in 2.1.2. It wasn't connected to any code anyway, so removing it didn't affect any functionality or output.

lpjirasync January 24, 2018 at 5:05 PM
**Comment from Launchpad by: Baron Schwartz on: 04-03-2012 23:50:01
I believe it's OK to remove this option. Let's target it for the next milestone, and during that time, we can write some code in OptionParser.pm to warn when a deprecated option is removed, eg:
--item --zero-bool
deprecated: yes; blah: blah
When such an option is given on the command line or in a file, the tool should print to STDERR something like this:
Warning: option '--zero-bool' is deprecated and will be removed in the next version of Percona Toolkit.

lpjirasync January 24, 2018 at 5:05 PM
**Comment from Launchpad by: Daniel Nichter on: 01-03-2012 17:22:01
Iirc, mk-query-digest used to print bools like "Full scan %0", i.e. just one value, the %true. That could result in "Full scan 0%" because all events were "Full_scan: No". So --no-zero-bool would suppress lines like "Full scan %0". However, the output format changed as early as pt-query-digest 1.0 because now the bools are like "Full scan 0% yes, 100% no". Since both %true(yes) and %false(no) are printed, there are no longer just zero lines, so --[no]zero-bool is useless. The option hasn't worked, so we might as well just remove it from the POD.
Details
Assignee
UnassignedUnassignedReporter
lpjirasynclpjirasync(Deactivated)Priority
Low
Details
Details
Assignee
Reporter

Priority
Smart Checklist
Open Smart Checklist
Smart Checklist
Open Smart Checklist
Smart Checklist

**Reported in Launchpad by Daniel Nichter last update 19-06-2012 20:05:01
pt-query-digest --[no]zero-bool doesn't work because the option isn't used. This was detected by util/check-tool.