Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

LP #821695: pt-query-advisor parses text within comments

Description

**Reported in Launchpad by Daniel Nichter last update 13-03-2013 15:04:20

Imported from http://code.google.com/p/maatkit/issues/detail?id=1250

Quoting the original:

While checking for rule 'STA.001', the tool seems to blindly scan the query for the pattern '!=', and reports it even if it appears in comments, thus incorrectly reporting that the query has a non standard operation.

e.g. A STA.001 note is generated for the query:
/* use <> instead of != */ SELECT a.col FROM table as a WHERE a.col2 = 20

Environment

None

Smart Checklist

Activity

Show:

lpjirasync January 24, 2018 at 5:07 PM

**Comment from Launchpad by: Daniel Nichter on: 13-03-2013 15:04:10

pt-query-advisor was removed in 2.2. Use pt-query-advisor 2.1 or the online tool: https://tools.percona.com/query-advisor.

This issue has been moved to https://github.com/percona/query-advisor/issues/4.

Won't Do

Details

Assignee

Reporter

Priority

Labels

Smart Checklist

Created January 24, 2018 at 5:06 PM
Updated February 4, 2018 at 2:11 AM
Resolved January 24, 2018 at 5:07 PM