LP #900544: pt-stalk will trigger collect even if mysql access fails, and pt-collect will also collect non-mysql data.

Description

**Reported in Launchpad by Fernando Ipar last update 10-11-2012 14:30:21

If the credentials for pt-collect are wrong, pt-stalk outputs an error, but still triggers pt-collect.
This is wrong, as pt-collect is unable to measure whatever variable is being monitored without mysql access.

Besides the bug, a feature request would be that pt-stalk fails upfront if mysql access doesn't work, or more generically, if it can't check it's condition against the threshold.

Here's a sample output from running with no mysql access:

[root@localhost ~]# ./pt-stalk
mysqladmin: connect to server at 'localhost' failed
error: 'Access denied for user 'root'@'localhost' (using password: NO)'
2011_12_05_21_26_38 The detected value is empty; something failed? Exit status is 0
2011_12_05_21_26_38 check results: Threads_connected = , matched = yes, cycles_true = 1
Gathering info for 2011_12_05_21_26_38
2011_12_05_21_26_38 sleeping 300 seconds to avoid DOS attack

Environment

None

Smart Checklist

Activity

Show:

lpjirasync January 24, 2018 at 6:10 PM

**Comment from Launchpad by: Brian Fraser on: 10-11-2012 14:30:20

Since we're no longer making patches for the 1.0 series, I'm marking this bug as Won't Fix there.

lpjirasync January 24, 2018 at 6:10 PM

**Comment from Launchpad by: Daniel Nichter on: 16-12-2011 16:04:32

This is bug is only valid in 1.0 because pt-stalk 2.0 does check MySQL access before running.

Not a Bug

Details

Assignee

Reporter

Priority

Smart Checklist

Created January 24, 2018 at 6:10 PM
Updated February 4, 2018 at 1:53 AM
Resolved January 24, 2018 at 6:10 PM

Flag notifications