Implement check to fail early if number of open file handles is not same as number of files in datadir

Description

Although this is a limitation for the initial release, we would like to fail with a better error message when the open file requirement for the REDUCED lock feature is not met.

Environment

None

Activity

Show:

Satya Bodapati October 4, 2024 at 12:36 PM
Edited

2024-10-04T13:36:28.394070+01:00 0 [Note] [MY-011825] [Xtrabackup] xb_check_and_set_open_files_limit is verifying the open_files limit for --lock-ddl=reduced
2024-10-04T13:36:28.394088+01:00 0 [Note] [MY-011825] [Xtrabackup] Current open file limits:
2024-10-04T13:36:28.394093+01:00 0 [Note] [MY-011825] [Xtrabackup] Desired file_handles: 1106
2024-10-04T13:36:28.394096+01:00 0 [Note] [MY-011825] [Xtrabackup] ulimit -Sn: 1024
2024-10-04T13:36:28.394100+01:00 0 [Note] [MY-011825] [Xtrabackup] ulimit -Hn: 1048576
2024-10-04T13:36:28.394103+01:00 0 [Note] [MY-011825] [Xtrabackup] --open-files-limit: 0
2024-10-04T13:36:28.394108+01:00 0 [Note] [MY-011825] [Xtrabackup] Reduced lock mode successfuly raised open files limit to 1106

Satya Bodapati October 4, 2024 at 12:29 PM
Edited

Different open files limit check messages:

FAILURE:
2024-10-04T13:25:17.895918+01:00 0 [Note] [MY-011825] [Xtrabackup] xb_check_and_set_open_files_limit is verifying the open_files limit for --lock-ddl=reduced
2024-10-04T13:25:17.895928+01:00 0 [ERROR] [MY-011825] [Xtrabackup] Reduced lock mode requires open file handles 1106 but the max limit (ulimit -Hn) is 1024

SUCCESS CASE (Hard limit is 1048576)

2024-10-04T13:26:57.777926+01:00 0 [Note] [MY-011825] [Xtrabackup] xb_check_and_set_open_files_limit is verifying the open_files limit for --lock-ddl=reduced
2024-10-04T13:26:57.777937+01:00 0 [Note] [MY-011825] [Xtrabackup] Reduced lock mode successfuly raised open files limit to 1106

FAILURE CASE( hard limit is 1048576 but --open-files-limit=300 passed)

2024-10-04T13:27:31.026531+01:00 0 [ERROR] [MY-011825] [Xtrabackup] Reduced lock mode needs open file handles: 1106 but --open-files-limit parameter is set to 300
2024-10-04T13:27:31.026536+01:00 0 [ERROR] [MY-011825] [Xtrabackup] Please retry with --open-files-limit=1106

Done

Details

Assignee

Reporter

Needs QA

Yes

Sprint

Priority

Smart Checklist

Created October 2, 2024 at 10:02 PM
Updated October 10, 2024 at 4:09 PM
Resolved October 4, 2024 at 12:42 PM