Xtrabackup based SST always runs version-check procedure

Description

Since the change of innobackupex to xtrabackup in PXC 5.7, from:

wsrep_sst_xtrabackup-v2:INNOBACKUPEX_BIN=innobackupex

 to

wsrep_sst_xtrabackup-v2:INNOBACKUPEX_BIN=xtrabackup

 and in 8.0 to:

pxb_bin_path="${pxb_root}/bin/xtrabackup"

 the following IF condition returns false, resulting in NOT using the --no-version-check option during SST. The responsible script fragment is in PXC 5.7:

if ${INNOBACKUPEX_BIN} /tmp --help 2>/dev/null | grep -q -- '--version-check'; then disver="--no-version-check" fi

 and in PXC 8.0:

if ${pxb_bin_path} /tmp --help 2>/dev/null | grep -q -- '--version-check'; then disver="--no-version-check" fi

 as xtrabackup returns error with /tmp option:

# xtrabackup /tmp --help xtrabackup: recognized server arguments: --datadir... xtrabackup: recognized client arguments: --port... xtrabackup: Error: unknown argument: '/tmp'

the condition returns false and not setting the $disver.

As a result, every SST process is doing the version check procedure.

Environment

None

AFFECTED CS IDs

CS0021400

Smart Checklist

Activity

Show:

Przemyslaw Malkowski October 14, 2021 at 3:01 PM

 yes it does, so that's a valid workaround.

Marcelo Altmann October 14, 2021 at 2:47 PM
Edited

what about adding to my.cnf:

[xtrabackup] no-version-check

Does it skip the test?

Done

Details

Assignee

Reporter

Time tracking

32m logged12m remaining

Affects versions

Priority

Smart Checklist

Created October 13, 2021 at 12:23 PM
Updated March 6, 2024 at 9:05 PM
Resolved January 28, 2022 at 1:00 PM

Flag notifications