pmm-dump export does not include host metrics when filtering on services

Description

When using a filter on service name with --instance paramter, every metrics such as “node_*” will be excluded.

--instance description is "Service name to filter instances. Use multiple times to filter by multiple instances"

https://github.com/percona/pmm-dump/blob/e85f85c441cefaccaa9048dd88c403d4a4e2373d/cmd/pmm-dump/main.go#L82

 

It works as expected, as it will add the correct filter to the selectors:

https://github.com/percona/pmm-dump/blob/e85f85c441cefaccaa9048dd88c403d4a4e2373d/cmd/pmm-dump/main.go#L190-L192

 

Problem is:

Any node_* metrics (so every metrics from OS dashboards) do not have service_name label, so they won’t match the query

For example, labels for node_cpu_seconds_total

A quick test on explore confirms it, filtering with a service_name that does exist won’t work:

Environment

None

AFFECTED CS IDs

CS0044498, CS0047539

Attachments

3

Activity

Show:

Jean da Silva July 11, 2024 at 10:50 AM
Edited

The issue is reproducible using pmm-dump GUI from PMM(tested with version 2.41.2)

Using the pmm-dump(0.7.0) tool instead, the issue did not happen.

  • Attached are both dumps from personal tests.

Done

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Smart Checklist

Created March 21, 2024 at 3:34 PM
Updated March 13, 2025 at 11:08 AM
Resolved March 13, 2025 at 11:08 AM