Issues
- pt-config-diff doesn't handle innodb_temp_data_file_path correctlyPT-1633Resolved issue: PT-1633Carlos Salguero
- LP #1629954: pt-config-diff does not allow different portsPT-1387Resolved issue: PT-1387
- LP #1550043: pt-config-diff doesn't parse some comments correctlyPT-1330
- LP #1489613: pt-config-diff does not detect variance in 'group_concat_max_len' variablePT-1302Resolved issue: PT-1302
- LP #1211377: pt-config-diff can't handle synonymsPT-1138
- LP #1175310: pt-config-diff does not handle multi-valued attributesPT-1105
- LP #889742: Should use SHOW GLOBAL VARIABLESPT-894Resolved issue: PT-894
- LP #1012893: pt-config-diff doesn't respect !includedirPT-781
- LP #1007938: pt-config-diff doesn't handle end-of-line commentsPT-780Resolved issue: PT-780
- LP #1086018: pt-config-diff needs to parse wsrep_provider_optionsPT-596Resolved issue: PT-596
- LP #1022622: pt-config-diff is case-sensitivePT-551Resolved issue: PT-551
- LP #1012647: pt-config-diff doesn't handle log_slow_verbosityPT-542
- LP #1008796: Several tools don't have --databasePT-538Resolved issue: PT-538
- LP #917770: pt-config-diff Use of uninitialized value in substitution (s///) at line 1996PT-452Resolved issue: PT-452
- LP #915598: pt-config-diff ignores --ask-pass optionPT-449Resolved issue: PT-449
- LP #889739: pt-config-diff doesn't diff quoted strings properlyPT-434Resolved issue: PT-434
pt-config-diff doesn't handle innodb_temp_data_file_path correctly
Description
Environment
Smart Checklist
hideDetails
Assignee
Carlos SalgueroCarlos Salguero(Deactivated)Reporter
DICT Systemen - Universiteit GentDICT Systemen - Universiteit GentPriority
MediumAffects versions
Fix versions
Labels
Smart Checklist Progress
1/1 - Done
Details
Details
Assignee
Reporter
Priority
MediumAffects versions
Fix versions
Labels
Smart Checklist Progress
Smart Checklist
Smart Checklist
Smart Checklist
Activity
Carlos SalgueroFebruary 1, 2023 at 2:38 PM
Hello,
It seems like the patch was overwritten by the tool to update embedded modules.
Could you please create a new PR modifying the MySQLConfig module and then apply the patch to all the scripts like this:
Thanks
DICT Systemen - Universiteit GentJanuary 25, 2023 at 12:57 PM
It seems, this bug was reintroduced in Percona Toolkit 3.5.1 : https://github.com/percona/percona-toolkit/blob/3.x/bin/pt-config-diff#L3321
it should be :
with a ^ before (\d+)
Can you reapply my PR? Or shall I create a new one again.
How can we avoid that my PR will disappear again in the future?
DICT Systemen - Universiteit GentJanuary 9, 2019 at 3:40 PM
Proposed solution in https://github.com/percona/percona-toolkit/pull/386
DICT Systemen - Universiteit GentJanuary 9, 2019 at 3:04 PM
This problem seems to be caused by this conversion, where the regexp matches any variable with a number followed by K, M, G or T :
https://github.com/percona/percona-toolkit/blob/3.0/bin/pt-config-diff#L3247
Lalit ChoudharyOctober 29, 2018 at 1:37 PM
Thank you for the report.
Validated as described. PT version 3.0.12
Test:
Parameter innodb_temp_data_file_path isn't handled correctly, when the 'max' parameter is used.
Without the max parameter in the config file, the output is as expected :
When the max parameter is added in the config, without restart of the server, the value in the config is mentioned as a number, not a string :
After restart of the server, the config value is mentioned correctly for the server, but is still faulty for the config file :
For reference, when changing the parameter again the config file, without restart of the server, the result from pt-config-diff is as expected. It shows the value of the configfile and the server correctly :
Version of pt-config-diff : pt-config-diff 3.0.12
Version of MySQL server : Server version: 5.7.23-23-log Percona Server (GPL), Release '23', Revision '500fcf5'