pbm delete-backup of specific backup type (logical/physical/etc)

Description

Add filter params to delete backups of a specific type like "logical", "physical", "incremental", "external", "selective".

Specs:

  • name: "--type"

  • short name: "-t"

  • kind: enum

  • allowed values: "logical", "physical", "incremental", "external", "selective"

  • behavior: lists all allowed backups of the specified type. On a user confirmation, delete listed backups.

internal: find backups of all types, and remove not-allowed backups from the result

Usage example:

pbm delete-backup --older-than=30d --type=logical

Environment

None

Activity

Dmytro Zghoba 
September 21, 2023 at 2:53 PM

just updated the ticket description. it was planned to be added to `cleanup` command (and there is implementation done), but actually, we have `delete-backup` command that is supposed to do exactly what we need. We need to sync the command logic to the latest PBM capacity and the `cleanup` command. And add the filter to it.

Dmytro Zghoba 
July 31, 2023 at 8:32 AM
(edited)

we need agreement that a physical is valid base snapshot (and do impl changes). then the PR will get additional correction.

at the end, pbm will consistently work.

another option: release what is ready. but later will change behavior and docs. (temporary inconsistence with pbm status, at least)

Kai Wagner 
July 31, 2023 at 8:26 AM

How far are we with the overall implementation? Looking at the PR, are we mostly done, or 90% or just at the beginning of this.

The overall priority is rather low for this, but if we're almost done, it's worth finishing. (discussed with ) 

Aaditya Dubey 
July 6, 2023 at 9:54 AM

Hi ,

Thank you for the report.

Done

Details

Assignee

Reporter

Labels

Needs Review

Needs QA

Needs Doc

Fix versions

Priority

Created July 5, 2023 at 2:04 PM
Updated March 5, 2024 at 6:37 PM
Resolved February 26, 2024 at 6:44 PM