Fix backup type in "another operation in progress" error message

Description

Currently, the message says that the ongoing operation is always a Snapshot, which is misleading. It would be better if it actually informed the backup type that is in progress.

I simulated it with PBM v2.7.0 and PSMDB v7.0.15. PBM shows Snapshot backup for both logical and physical backups.

$ pbm backup; pbm backup -t physical --profile=minio_profile Starting backup '2024-12-11T17:44:21Z' ....Backup '2024-12-11T17:44:21Z' to remote store '/bigdisk/pablo.claudino/cs0051642/backup' Error: another operation in progress, Snapshot backup/6759cf75195178dd4ccf4f4a [rs01/localhost:28019] $ pbm backup -t physical; pbm backup -t physical --profile=minio_profile Starting backup '2024-12-11T17:48:41Z'....Backup '2024-12-11T17:48:41Z' to remote store '/bigdisk/pablo.claudino/cs0051642/backup' Error: another operation in progress, Snapshot backup/6759d0792a02a392434c29d4 [rs01/localhost:28019]

Proposed solution

“Snapshot backup” is a command type we have in the code - we can simplify the naming into just “backup”. Optionally, we can add additionally parameters to the message (and log events) such as “Physical” or “Logical”. To think how to handle for other commands such as “restore” or “delete”.

Environment

None

AFFECTED CS IDs

CS0051642

Activity

Show:

Aaditya Dubey December 23, 2024 at 1:26 PM

Hi

Thank you for the report and feedback.

Details

Assignee

Reporter

Labels

Needs QA

Yes

Affects versions

Priority

Smart Checklist

Created December 11, 2024 at 5:53 PM
Updated January 7, 2025 at 12:43 PM

Flag notifications