Missed config file checks for pbm-agent.

Description

Steps:
1. Create incorrect yml config
2. Start pbm-agent
Example:

yml config

Expected result:

Cannot start because config is incorrect

Actual result:

Pbm agent started without errors.

PBM commit:

63a8b2031b35816edcb175b837ffdd0c74ed3187

Environment

None

Activity

Akira Kurogane November 22, 2019 at 1:55 AM

forces values to only be only the expected ones, i.e. forces them to be correct.

But they could still be incomplete; the config set by the current version may become invalid in hypothetical future version with different config, and somehow the pbmConfig collection may be altered where it is in the admin db by another means (e.g. somehow thinking 'I don't recognize that, I'll drop it').

So we can't test this by attempting to insert a bad config file now (thanks to work), but we could test that if we deliberately damage the pbmConfig collection that it makes a sensible error message and exits with a non-zero exit code.

Rough idea for test:

Done

Details

Assignee

Reporter

Labels

Time tracking

10m logged

Fix versions

Affects versions

Priority

Created June 17, 2019 at 8:56 AM
Updated March 5, 2024 at 7:25 PM
Resolved January 4, 2020 at 5:47 PM