Last two rows are not visible when scrolling data tables

Description

Vertical scrollbars on graph elements are missed sometime. It have even a different size in comparing to a clear grafana version for the same element. IMHO it's related to the fact that we have no bottom border.

PMM 2.2.0 (Grafana 6.5.2)

play.grafana.org (Grafana 6.5.2)

Here is docker with Grafana 6.5.2
perconalab/pmm-server-fb:PR-617-eed39e8

How to test

None

How to document

None

Attachments

11
  • 05 Feb 2020, 11:12 AM
  • 04 Feb 2020, 03:07 PM
  • 10 Jan 2020, 12:01 PM
  • 10 Jan 2020, 12:01 PM
  • 10 Jan 2020, 12:01 PM
  • 08 Jan 2020, 03:11 PM
  • 08 Jan 2020, 03:10 PM
  • 08 Jan 2020, 02:10 PM
  • 08 Jan 2020, 02:09 PM
  • 08 Jan 2020, 02:01 PM
  • 08 Jan 2020, 02:01 PM

Smart Checklist

Activity

Nailya Kutlubaeva February 6, 2020 at 9:17 AM

I tested FB and it work ok, can be merged

Vadim Yalovets February 5, 2020 at 11:13 AM

The issue is fixed by patch changes

FB:
perconalab/pmm-server-fb:PR-664-e4b2862

Alex Demidoff February 4, 2020 at 9:51 PM

The root cause of this bug has been found. It leaked in with patches for `grafana-share-panel` component.
The link: https://github.com/percona/pmm-server-packaging/blob/master/rhel/SOURCES/grafana-5.4.5-share-panel.patch#L139

HOW TO FIX:

  • set the value of `max-height` property back to 35% which is the original value

  • PR to pmm-server-packaging

Vadim Yalovets February 4, 2020 at 3:08 PM

It looks like the issue is related to our grafana build.
I removed percona-grafana package and tried original grafana packages.
Scroll and bottom boards are exist for both grafana versions:
6.6.0 (latest)
6.5.2 (used for our build)

[root@1dbefaf264c2 grafana]# yum list installed | grep grafana grafana.x86_64 6.6.0-1 @grafana [root@1dbefaf264c2 grafana]# yum list installed | grep grafana grafana.x86_64 6.5.2-1 @grafana

Roman Misyurin January 22, 2020 at 10:58 AM

I couldn't found root cause in our code, now it seems like it's grafana's bug, trying to understand the difference between play.grafana build and ours.

Done

Details

Assignee

Reporter

Priority

Labels

Needs QA

Yes

Needs Doc

No

Fix versions

Story Points

Sprint

Affects versions

Smart Checklist

Created January 7, 2020 at 9:55 AM
Updated July 18, 2024 at 2:23 PM
Resolved February 7, 2020 at 10:05 PM

Flag notifications