Alert Rules - Edit

Description

User Story: 

  • As a PMM admin user, I need to be able to Edit Alert Rule so it will be used for execution and alerting by specified channels when the Criteria are met. 

 

UI:

 

 Acceptance Criteria: 

  • The user is able to press the Edit icon on the List 

  • The user is able to change fields in the Form

  • As a User, when I trigger an action that successfully resolves, I can see a success notification.

  • As a User, when I trigger an action that errors out, I can see an error notification.

  • HTML title

 

Implementation details:

  • code and PRs get pushed to percona-platform/grafana repository

  • test coverage

  • honor light/dark mode

 

Out of Scope:

  • Custom labels 

  • Filters - just plain text, no multi-selector 

How to test

None

How to document

None

Attachments

2

Smart Checklist

Activity

Show:

Zoriana Stefanyshyn December 28, 2020 at 10:18 AM

please take a look at the following issues I found:

  1. I edit some rules and save changes. Then I press ADD to add a new rule and I see "Edit form (with not all fields present)"

  2. Edit form name is "Add Alert rule"

  3. "Aler rule created" notification shown after successful update

  4. Why not just disable fields that can not be editable that the user understands the name of the rule he is currently editing?
    cc:

Nicola Lamacchia December 23, 2020 at 11:52 PM

 I found out by myself that not all of them are editable, template and name are not editable, therefore they won't show up in the editing modal

vasyl.yurkovych December 4, 2020 at 12:38 PM

 all fields are editable during Edit? for example are we allowed to select another Template for the Rule?

Done

Details

Assignee

Reporter

Priority

Needs QA

Yes

Fix versions

Story Points

Sprint

Smart Checklist

Created November 24, 2020 at 9:40 AM
Updated November 13, 2024 at 9:50 AM
Resolved December 29, 2020 at 10:12 PM