LP #1072573: Missing mutex != NULL check in i_s_innodb_fill_buffer_pool()
General
Escalation
General
Escalation
Description
**Reported in Launchpad by Laurynas Biveinis last update 21-06-2013 09:06:29
Taking this from the MP review as it was submitted too late:
My previous review comment was misleading, sorry about that: buf_page_get_mutex_enter() is better than buf_page_get_mutex() and mutex_enter() combination by preventing a race condition between the calls and not calling mutex_enter on NULL. But it still might return NULL, thus mutex_exit() still has to be conditional in i_s_innodb_fill_buffer_pool().
**Reported in Launchpad by Laurynas Biveinis last update 21-06-2013 09:06:29
Taking this from the MP review as it was submitted too late:
My previous review comment was misleading, sorry about that: buf_page_get_mutex_enter() is better than buf_page_get_mutex() and mutex_enter() combination by preventing a race condition between the calls and not calling mutex_enter on NULL. But it still might return NULL, thus mutex_exit() still has to be conditional in i_s_innodb_fill_buffer_pool().