Updating auto increment value causes server to "go away" [ZN7myrocks10ha_rocksdb31update_auto_incr_val_from_fieldEv]

Description

gdb info

Testcase:

Version (release branch for RM-321):

Environment

None

Smart Checklist

Activity

Show:

George Lorch February 15, 2018 at 5:55 PM

These crashes are limited to auto increment columns that are of DOUBLE or FLOAT type only. Not at all a common use case. Particularly in a largely unused storage engine. Upstream already has responded to the issue and provided fixes.

roel.vandepaar February 15, 2018 at 8:53 AM
Edited

These crashes are seen all through the runs (screenfillers). This basically breaks auto_increment as we know, is a serious bug, and it makes MyRocks un-GA imho. I am setting this to "blocker" as that is what it is IMHO. Could we un-cherry-pick the offending patch from the tree to make MyRocks stable again before release?

George Lorch February 12, 2018 at 4:57 PM
Edited

Reproducible upstream on prod201704, likely introduced by one of these five commits :

NOPE  https://github.com/facebook/mysql-5.6/commit/bb8183d38b401a0c24dcebb785d624ad34fe755f : Load autoincrement and hidden pk only once

NOPE https://github.com/facebook/mysql-5.6/commit/9f53fae746084823d35177b70a314d14c93a441b : Implement inplace alter for auto_increment

NOPE https://github.com/facebook/mysql-5.6/commit/3e68a8cd409ea63e296a5c788daec188d3a4b864 : Fix loading auto_increment values in tables with hidden pk

NOPE https://github.com/facebook/mysql-5.6/commit/b016d55a315277c0adf07d330bdeb9172f283b44 : Implement persistent auto_increment values

>>> this one >>> https://github.com/facebook/mysql-5.6/commit/4d66a663abfa60c6c1739d0612959b3457b5f2b1 : Fix auto_increment bugs with large values

 

Hrvoje Matijakovic February 12, 2018 at 2:59 PM
Edited

Found similar issue with different error string (ZN7myrocks10ha_rocksdb18get_auto_incrementEyyyPyS1):

Test case:

Done

Details

Assignee

Reporter

Time tracking

4h 3m logged

Components

Fix versions

Affects versions

Priority

Smart Checklist

Created February 12, 2018 at 11:02 AM
Updated March 6, 2024 at 1:31 PM
Resolved February 16, 2018 at 3:41 AM