Fail to compile on jenkins yakkety

Description

Task is a child of

RocksDB fails to compile on our jenkins yakkety with these errors, unknown why as this should be gcc 4.8 with c++11 support:

Environment

None

Smart Checklist

Activity

Show:

Sergei Glushchenko April 11, 2017 at 12:59 PM

Sergei Glushchenko April 10, 2017 at 5:09 PM

With this fixed build succeeds

Sergei Glushchenko April 10, 2017 at 5:08 PM

Method declared with attribute nonnull

and then compared to null:

Which means if m_maybe_unpack_info is not null then pk_unpack_info should be not null. Either attribute nunnull should be removed, or assert should be removed.

Some time ago MySQL codebase went through code cleanup, when attribute nonnull has been removed from most of the places.

George Lorch April 6, 2017 at 9:29 PM

Hey Sergei Glushchenko I_think_ the cxx flags for MyRocks weren't all getting set/reset properly with -std=c++11
Please see this current PR as yakkety builds correctly now with these changes https://github.com/percona/percona-server/pull/1632

  • update, well, release builds, debug still fails with this error, but this IMHO is much more managable:

Done

Details

Assignee

Reporter

Components

Fix versions

Priority

Smart Checklist

Created April 5, 2017 at 5:58 AM
Updated December 27, 2018 at 9:10 PM
Resolved April 14, 2017 at 3:13 PM