MyRocks altering a column/table comment rebuilds a table

Description

Modifying a comment for a column or table should be instant operation.
This one was already fixed for TokuDB here: https://jira.percona.com/browse/PS-4280
and it is also probably related to this one: https://jira.percona.com/browse/PS-5031
but this one only applies to RocksDB and is not 8.0 specific so decided to open a separate issue.
Comments in RocksDB have special meaning for using column families but only when they are used on indexes so this might be a bit harder to fix for RocksDB vs TokuDB.

Here's to show that it's not instant operation for RocksDB:
8.0.12 RocksDB

8.0.12 InnoDB:

8.0.12 TokuDB:

5.7.23 RocksDB:

5.7.23 InnoDB:

5.7.23 TokuDB:

Environment

None

Smart Checklist

Activity

Show:

Julia Vural March 4, 2025 at 9:07 PM

It appears that this issue is no longer being worked on, so we are closing it for housekeeping purposes. If you believe the issue still exists, please open a new ticket after confirming it's present in the latest release.

George Lorch December 12, 2018 at 7:27 PM

OK, so altering a table comment in MyRocks really can't be done inline due to TTL functionality.  If a user was changing the TTL specification, the table needs to be rebuilt/copied with the new TTL stored within each key.  We can't (easily) check the table or index comments for the TTL specification at the point that we have to make the decision on whether or not an inplace alter can be performed.  So this is one that will probably have to be sent upstream to consider and will likely never get corrected.  There is a similar issue with column families and index comments where we just can't determine 1) what the users intentions are w.r.t. a comment change; and 2) if the comment change would force the move of and index from one column family to another at the point where we need to decide if we can support inplace alter for the operation.

George Lorch November 27, 2018 at 3:26 PM

This is not specific to 8.0. Fix for 5.7 and 8.0 will be somewhat different due to changes in 8.0 user interface from . Not likely to be a large amount of time. Maybe 'Fix if time' but this is really a minor thing, when one considers other holes in ALTER (like INPLACE not supported in 8.0).

Peter Schwaller November 27, 2018 at 1:11 PM

8.0 Triage meeting would like your recommendation on this one.

Won't Do

Details

Assignee

Reporter

Time tracking

3h 8m logged

Components

Affects versions

Priority

Smart Checklist

Created November 19, 2018 at 12:43 PM
Updated March 4, 2025 at 9:07 PM
Resolved March 4, 2025 at 9:07 PM