LP #1222709: Bug 951588 fix needs revert and re-fixing

Description

**Reported in Launchpad by Laurynas Biveinis last update 21-07-2015 12:14:48

Bug 951588 was about the fact that calling handler ::info from another thread is inherently unsafe because it overwrites the handler state, causing troubles for the handler-owning thread. The fix was to clone handler first, and then run ::info on the cloned handler.

This fix is very fragile: see bug 1113388, bug 1193264, bug 1193308, bug 1206486, bug 1205200, bug 1204859, bug 1206020, and probably others. handler::clone() was not designed for such use.

A better is fix is needed. One option would be to implement new small info-like method for handler that returns the already-available information from the handler without doing a full clone nor info.

Environment

None

Activity

lpjirasync 
January 20, 2018 at 6:45 PM

**Comment from Launchpad by: Laurynas Biveinis on: 21-07-2015 12:14:32

Un-duplicated the individual I_S.GLOBAL_TEMPORARY_TABLES bugs, and will fix the analysed ones without moving away from the use of handler::clone. That should allow GLOBAL_TEMPORARY_TABLES to become subject to QA again, and then the remaining i-s-temp-tables bugs can be fixed as they are analyzed or as the testcases are produced by QA.

lpjirasync 
January 20, 2018 at 6:44 PM

**Comment from Launchpad by: Laurynas Biveinis on: 15-09-2014 09:03:30

Not a regression because it is not fixed in the first place yet.

lpjirasync 
January 20, 2018 at 6:44 PM

**Comment from Launchpad by: Roel Van de Paar on: 11-09-2014 04:39:23

Bug 1367922 - regression?

lpjirasync 
January 20, 2018 at 6:43 PM

**Comment from Launchpad by: Laurynas Biveinis on: 12-12-2013 12:41:10

i37704 analyzed, it is a different problem.

The current issue is close to the top of my TODO.

lpjirasync 
January 20, 2018 at 6:43 PM

**Comment from Launchpad by: Roel Van de Paar on: 12-12-2013 07:43:19

Bug 1260151 & bug 1260154 were marked duplicate of this one also.

Laurynas, can we push this forward? We keep running into these sort of issues and it makes run analysis hard.

Done

Details

Assignee

Reporter

Priority

Created January 20, 2018 at 6:42 PM
Updated January 20, 2018 at 6:45 PM
Resolved January 20, 2018 at 6:43 PM