Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

checking for wsrep_node_address in wsrep_sst_common uses the wrong variable

Description

As per bug fix in , the commit introduces regression. Command replaces underscore ("") to dashes ("-") in `awk -F= '{if ($1 ~ //) { gsub(/_/,"-",$1); print $1"="$2 } else { print $0 }}'`, however, the search operation does not replace `grep – "--$var="`

 

Therefore, `wsrep_node_address=$(parse_cnf mysqld wsrep_node_address "")` in wsrep_sst_xtrabackup-v2 will fail because wsrep_node_address does not correspond to wsrep-node-address

Environment

None

Smart Checklist

Activity

KennT November 13, 2018 at 8:16 AM

commit 1fc79202e5c01532a1d3213465f5c00586c3d3e0
Author: Kenn Takara <kenn.takara@percona.com>
Date: Thu Nov 8 05:32:42 2018 -0800

: checking for wsrep_node_address in wsrep_sst_common uses the wrong variable

Issue
The check for wsrep_node_address looks for 'wsrep_node_address' but
parse_cnf() normalizes the names from my_print_defaults by changing
'_' to '-'. So this means that we will never match these two names.

Solution
Change the calling code to use 'wsrep-node-address' instead of
'wsrep_node_address'. Also remove some code that searches for
variables using underscores (since the code does nothing).

KennT November 8, 2018 at 12:45 PM
Edited

Reducing the severity of this bug. This just causes the warning to be printed out unnecessarily.

Done

Details

Assignee

Reporter

Time tracking

1d 1h logged

Fix versions

Priority

Smart Checklist

Created November 5, 2018 at 6:53 AM
Updated March 6, 2024 at 10:24 PM
Resolved November 13, 2018 at 8:17 AM