Issues

Select view

Select search mode

 

PITR options are not available on UI if there are no schedules

Unresolved

Description

Problem:

PITR options are not available on UI if there are no schedules, even though the last backup was successful and the PITR is on.

Cause:

UI sets db.spec.backup.enabled to false if there are no schedules, which makes the /pitr endpoint think that the whole backup section is disabled so it returns an empty response.

 

Proposed solution:

[UI] do not use db.spec.backup.enabled, rely on the schedules amount instead. There is no such thing in Everest UI like “disable the whole backup section”, so the field should not be used.

[API] Deprecate the db.spec.backup.enabled field and don’t use it anymore. Delete the checks that are in place.

[Operator] Deprecate the db.spec.backup.enabled field and don’t use it anymore. Instead of checking db.spec.backup.enabled, check the length of the schedules list, it will keep the operator logic which is already in place. Btw, only psmdb has that .backup.enabled field, the pxc and pg does not have anything like that. So such field in the Everest db CR is confusing and does not make any sense.

Environment

None

Attachments

16
100% Done
Loading...

Details

Assignee

Reporter

QA

Story Points

Fix versions

Affects versions

Priority

Smart Checklist

Created November 7, 2024 at 9:48 AM
Updated March 7, 2025 at 4:15 PM

Activity

Show:

Edith Erika Puclla ParejaMarch 7, 2025 at 9:36 AM

Amazing , let’s move the ticket to Ready to Mergue then!!
Thanks a lot!!

Oksana GrishchenkoMarch 7, 2025 at 8:25 AM

Hi ! Looks like now it works as expected. Previously, the main problem was that the button was disabled while the pitr options were available. Both elements should be either enabled or disabled, which we see now in your test. Thank you!

Edith Erika Puclla ParejaMarch 6, 2025 at 4:47 PM

I tested again, and this is the behaviour for MYSQL.

New MYSQL Database, there is a BACKUP, but not SCHEDULE BACKUPS

  1. Point-Time Recovery (PITR) Disabled

  2. When creating a DB from a backup, the text box and button are disabled when clicking on the option “From a Point-in-time(PITR).”

  3. The same happens when we “Restore from a backup“ … I am guessing this is the correct behaviour.

A MySQL Database, with a BACKUP and a SCHEDULE BACKUP executed

  1. I edited PITR and enabled it.

  2. Then, I entered the database, and I created a new register in the database 16:13:07.

  3. After one minute, I tried to restore the database from PITR. The last transaction in the database was 16:13, so this is registered in the Restore database Window as well.

  1. The same behaviour happens when I create a New Database from a PITR.

 

I tried to reproduce the error from yesterday, BUT I COULD NOT NOW; every time I try to make a PITR Restore, the button and the text are activated.

 

As we discussed yesterday, the button and the text box should both be available because there was a transaction and scheduled backups, so they should be activated. Now it is working as expected, but yesterday the button was disabled. is this correct?
Thank youu!!!!

Edith Erika Puclla ParejaMarch 5, 2025 at 4:30 PM

OKie I will test tomorrow with this new FB

Edith Erika Puclla ParejaMarch 5, 2025 at 4:29 PM
Edited

Nice, Oksana, I am attaching the previous screenshot from our Slack conversation, so it could be useful for any moment.