Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Issues

Go to all issues
Select view

Select search mode

 
100 of

pt-diskstat is not working for new kernels

Done

Description

Kernel version 5 is already on some customers and the new amount of lines is 20.

At least this piece of code should be reviewed and changed:

sub parse_diskstats_line { my ( $self, $line, $block_size ) = @_; # linux kernel source => Documentation/iostats.txt # 2.6+ => 14 fields # 4.18+ => 18 fields my @dev_stats = split ' ', $line; return unless @dev_stats == 14 or @dev_stats == 18;

Environment

None

Smart Checklist

Details

Assignee

Reporter

Priority

Components

Affects versions

Fix versions

Story Points

Smart Checklist

Created September 9, 2020 at 6:42 PM
Updated February 29, 2024 at 8:57 PM
Resolved January 27, 2022 at 1:06 PM

Activity

Show:

Roma NovikovJanuary 27, 2022 at 1:06 PM

moved this to Pending release as this is already merged 

Lenz GrimmerDecember 3, 2021 at 3:09 PM

Pull request: PT-1887: Fixed pt-diskstats to work on 5.x kernels

Lenz GrimmerDecember 3, 2021 at 1:34 PM

FWIW, this bug makes pt-diskstats to simply hang on my Fedora 34 system (running Linux 5.15.4).

Lalit ChoudharyOctober 2, 2020 at 11:15 AM

Hi  David,

Thank you for the report.

Flag notifications