Issues

Select view

Select search mode

 
50 of

CentOS7 linux-metrics errors logged after update from older versions to 1.17.2.

Done

Description

The problem: Textfile collector feature is not working by default (with default file location )
Additionally, there are error messages in the log

Affected versions: Updated version of pmm1

Workaround: rename the folder from textfile-collector to textfile_collector

Original Issue:

Solution:
1) Fix the code to work with `textfile-collector` folder
2) Make sure we renamed from folders to proper one during the update

 

Versions need to be checked:

  • 1.16.0

  • 1.17.1

  • 1.17.2

 

Original report:

I updated pmm-client on CentOS7 a week ago now noticed 180MB of pmm-linux-metrics log filed with:

time="2019-11-03T22:35:51+02:00" level=error msg="Error reading textfile collector directory /usr/local/percona/pmm-client/textfile_collector: open /usr/local/percona/pmm-client/textfile_collector: no such file or directory" source="text
file.go:81"

I downgraded to 1.17.1 and the messages are gone.

pmm-client-1.17.1-1.el7.x86_64
pmm-client-1.17.2-1.el7.x86_64

It seems some script is looking for:

/usr/local/percona/pmm-client/textfile_collector

but the correct file is: /usr/local/percona/pmm-client/textfile-collector, with a hyphen.

For now I renamed textfile-collector to textfile_collector to suppress the error message.

 

How to test

None

How to document

None

AFFECTED CS IDs

270979

Smart Checklist

Details

Assignee

Reporter

Priority

Components

Needs QA

Yes

Needs Doc

Yes

Fix versions

Story Points

Sprint

Affects versions

Environment

OS: CentOS 7

Smart Checklist

Created November 4, 2019 at 5:54 PM
Updated October 9, 2024 at 8:36 AM
Resolved January 15, 2020 at 9:34 PM

Activity

Nailya KutlubaevaJanuary 14, 2020 at 8:24 AM
Edited

I checked upgrade from different versions and it seems everything is ok. There was a problem with deleting textile-collector directory, but it was fixed in 1.17.3. Thank you, !

Carlos SalgueroJanuary 8, 2020 at 7:14 PM

It is fixed in 1.7.x

Tested:

1.16.0: Error

1.17.0: No errors

1.17.1: No errors

1.17.2: No errors

Carlos SalgueroDecember 19, 2019 at 3:27 AM

Node exporter in .x branch had a wrong config file name (was using _ instead of -)

Nailya KutlubaevaDecember 13, 2019 at 8:39 AM

it seems the bug is still reproducible:
I installed latest pmm-client package from testing repository and then add linux to monitoring:

pmm-client-1.17.3-1.el6

Could you look into it?

Roma NovikovNovember 28, 2019 at 10:58 AM

Thanks for this report. this is a typo in the code ( we'll try to fix it and release patch release asap

Flag notifications